Merged
Conversation
Owner
|
I'm not entirely sure in what case this helps. Could you elaborate on this? |
Contributor
Author
|
It's useful because a) It's a sanity check that you're not doing anything that breaks the pyodide build, and b) if you want to fork and make a minor change you can just change it in your fork on github and download the build artifact without having to install anything at all (or know how to) build a pyodide package It's most relevant on a package with C extensions, but I put this action into all my pyodide things just so I can see they build okay (and typically I chuck another action which does the release and adds the artifact to it, and one could also potentially auto push to pypi when you add a new version tag, so pypi always tracks github releases nicely) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a simple github action which builds the wheel in pyodide build system and uploads it as a build artifact. Saves having to manually build it if you modify a fork.