Skip to content

added github workflow file#9

Merged
koenvo merged 2 commits intokoenvo:mainfrom
joemarshall:ci_only
Oct 4, 2022
Merged

added github workflow file#9
koenvo merged 2 commits intokoenvo:mainfrom
joemarshall:ci_only

Conversation

@joemarshall
Copy link
Contributor

This is a simple github action which builds the wheel in pyodide build system and uploads it as a build artifact. Saves having to manually build it if you modify a fork.

@koenvo
Copy link
Owner

koenvo commented Sep 30, 2022

I'm not entirely sure in what case this helps. Could you elaborate on this?

@joemarshall
Copy link
Contributor Author

It's useful because a) It's a sanity check that you're not doing anything that breaks the pyodide build, and b) if you want to fork and make a minor change you can just change it in your fork on github and download the build artifact without having to install anything at all (or know how to) build a pyodide package

It's most relevant on a package with C extensions, but I put this action into all my pyodide things just so I can see they build okay (and typically I chuck another action which does the release and adds the artifact to it, and one could also potentially auto push to pypi when you add a new version tag, so pypi always tracks github releases nicely)

@koenvo koenvo merged commit be83d60 into koenvo:main Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants