Scope table filtering: support scoped Table Filter, refine matching and loading behavior#10
Merged
koianaoki merged 1 commit intoMay 11, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
self._tree_filter_scope_pathand conditioned loading, counting, matching, and visibility logic on that flag inTreeFilterMixin._tree_filter_should_descend_nodeto control whether children are inspected during filtering and tightened_tree_filter_can_match_nodeto restrict default matches to connection/database types while scoped filters match tables only._update_tree_filter,_find_matching_nodes,_count_all_nodes,_ensure_tree_filter_search_nodes_loaded,_tree_filter_node_has_pending_load,_apply_filter_to_tree,_jump_to_current_match, andaction_tree_filter_acceptto handle scoped vs unscoped behavior correctly, and preserved main filter behavior for activation and cursor restoration._tree_filter_should_descend_nodeinExplorerActionsProtocoland adjusted label/visibility handling to preserve highlight and pending-load semantics.tests/ui/test_tree_filter_tables_scope.pyto validate scoped searches, loading behavior, and accept/activation behavior.Testing
tests/ui/test_tree_filter_tables_scope.pywhich include expanded scenarios for scoped table filtering, folder loading behavior, and accept/activation; all tests passed.TreeFilterMixinbehaviors for both scoped (action_table_filter) and unscoped (action_tree_filter) flows via the test suite, and assertions for cursor, selection, loading calls, and visibility succeeded.Codex Task