Remove explorer table column expansion#15
Conversation
|
@codex 日本語でレビュー |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e4694e2c68
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| child.allow_expand = True | ||
| if expansion_state.get_node_path(host, child) in expanded_paths: | ||
| child.expand() | ||
| child.allow_expand = False |
There was a problem hiding this comment.
この変更でテーブル/ビューが allow_expand=False になると、Textual の toggle_node は何もしなくなりますが、TreeOnTableState はまだフッターに Enter を Columns として表示しています。そのためテーブル/ビューにフォーカスしたユーザーには、実際には動作しない「Enter でカラム表示」が案内されます。show_table_columns へ案内を差し替えるか、Enter の表示を削除してください。
Useful? React with 👍 / 👎.
|
@codex 指摘が治ったか確認 |
|
Codex Review: Didn't find any major issues. Keep it up! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Motivation
Tables,Views) to avoid reloading per-table column children.Description
table/viewbranch in the tree expansion handler so table/view nodes no longer triggerload_columns_asyncfromsqlit/domains/explorer/ui/mixins/tree.py.sqlit/domains/explorer/ui/tree/loaders.pyto only consider folder nodes (changed_should_load_expanded_nodeto requirekind == "folder").child.allow_expand = Falseinsqlit/domains/explorer/ui/tree/schema_render.pyso they do not appear expandable in the UI.tests/ui/explorer/test_tree_expansion.py,tests/ui/test_tree_schema_grouping.py,tests/ui/explorer/test_refresh_expanded_loads.py,tests/ui/explorer/test_markup_escaping.py, andtests/integration/test_stale_connection_reconnect.py.Testing
python -m compileall -qfor the changed files and compilation succeeded.git diff --checkto validate no whitespace/diff issues and it returned clean results.tests/ui/explorer/...etc.), but test execution was blocked by missing dependency:ModuleNotFoundError: No module named 'textual'so the UI tests could not be executed in this environment.Codex Task