Explorer: add table metadata shortcuts, regex tree-filter, and MySQL index fix#3
Merged
koianaoki merged 1 commit intoMay 11, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
show_table_columnsandshow_table_indexesin the default keymap and updated tests to assert their presence.TreeOnTableStatefooter bindings to expose the new metadata shortcuts and addedTreeMixinimplementations foraction_show_table_columnsandaction_show_table_indexeswith MySQL-specificSHOW FULL COLUMNS/SHOW INDEXhelpers and a generic schema-service fallback; added helpers_selected_table_node_data,_is_mysql_like_provider,_format_mysql_table_reference,_show_mysql_full_columns,_show_mysql_indexes, and_index_table_matches.TreeFilterMixinwith parsing of prefixes (/,re:,r:), compiled pattern caching, matching/highlighting logic, and new state fields; importedreand added protocol fields inshared/ui/protocols/explorer.py.MySQLBaseAdapter.get_indexesto stop excludingPRIMARYand adjusted a type annotation onapply_database_override; replaced uses ofsetattr(self, "_schema_load_request_token", ...)with direct assignment.Testing
tests/unit/test_tree_filter.pyandtests/unit/test_mysql_indexes.py, and they passed.tests/ui/explorer/test_table_metadata_shortcuts.pyandtests/ui/keybindings/test_keymap_provider.py, and they passed.Codex Task