Restore tree filter behavior and API signature (remove slash-prefix handling)#8
Merged
koianaoki merged 1 commit intoMay 11, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
/and the API remains a no-argument action.Description
action_tree_filtersignature back todef action_tree_filter(self) -> Noneand initializeself._tree_filter_textto an empty string insqlit/domains/explorer/ui/mixins/tree_filter.py./(calls now useself.action_tree_filter()instead of passing"/") in the same mixin's key handling logic.tree_filter_input.set_filternow receives an empty string for the filter text (restoring prior display behavior).sqlit/shared/ui/protocols/explorer.pyto match the restored no-argument signature and removed the tests that asserted the slash-prefix behavior intests/unit/test_tree_filter.py.Testing
uv run pytest tests/unit/test_tree_filter.pyand all tests passed (5 passed).Codex Task