Add scoped Explorer table filtering#9
Merged
koianaoki merged 6 commits intoMay 11, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
_tree_filter_scope_path) when the tree filter is opened and introduce_get_tree_filter_scope_path/_get_tree_filter_search_roothelpers to resolve the scoped subtree._update_tree_filter,_ensure_tree_filter_search_nodes_loaded,_find_matching_nodes,_apply_filter_to_tree, and_count_all_nodes.sqlit/shared/ui/protocols/explorer.py) to expose the new scope and helper signatures required by the mixin.tests/ui/test_tree_filter_tables_scope.py) that verify starting the filter on a Tables folder or on a table uses the Tables subtree as the filter scope.Testing
uv run pytest tests/ui/test_tree_filter_tables_scope.py -q, which passed (2 passed).uv run ruff check ...which reported no issues.uv run mypy ...which completed with no issues.Codex Task