Fix/reliability

[4rthurCai]

Related Issue

Summary

Change Type

• New Feature (feat)
• Bug Fix (fix)
• Refactoring (refactor)
• Documentation (docs)
• Dependency / Configuration (chore)

Self-Check Checklist

Backend (Go):

• go build ./... passes
• go vet ./... passes
• gofmt produces no diff

Frontend (Vue):

• npm run lint passes
• npm run typecheck passes

General:

• Removed all temporary debug output
• No sensitive data in the code

Test Steps

1. Pull branch and install dependencies:

   cd backend && go mod download
   cd ../frontend && npm install

2. Start the application:

   make dev-backend    # Terminal 1
   make dev-frontend   # Terminal 2

3. Verification steps:
   • ...

[Copilot]

Pull request overview

This PR focuses on reliability-oriented refactors and small UX/accessibility tweaks across the frontend and backend, aiming to reduce complexity, centralize repeated logic, and improve runtime behavior consistency.

Changes:

• Frontend: refactors for readability/typing, improves service worker registration handling, and adds/adjusts accessibility attributes and UI color variables.
• Backend: refactors service logic into helpers/constants, improves context propagation in chat, and simplifies router wiring by grouping handlers.
• General: reduces duplicated code paths (e.g., interaction handlers, chat memory helpers) and standardizes some formatting.

Reviewed changes

Copilot reviewed 37 out of 37 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
frontend/src/utils/spriteOffset.ts	Formatting + minor parsing/API usage cleanup for sprite offset calculation.
frontend/src/utils/random.ts	Refactors seeded PRNG implementation (see review comment re: int32 wrap semantics).
frontend/src/styles/variables.css	Adjusts secondary text color variable.
frontend/src/main.ts	Changes SW registration to await within try/catch in production.
frontend/src/lib/auth.ts	Changes thrown error type for API error responses (see review comment re: TypeError).
frontend/src/lib/apiClient.ts	Adds typed _retry request config and refactors interceptor rejection handling (see review comment re: error.config).
frontend/src/constants/seagulls.ts	Formatting/standardization of constant data definitions.
frontend/src/constants/reflections.ts	Formatting/standardization + minor numeric literal normalization.
frontend/src/composables/useTutorial.ts	Simplifies spriteId extraction and callback flow when offset is null.
frontend/src/composables/useParallax.ts	Refactors wheel delta selection + switches some globals to globalThis (see review comment re: timer typing).
frontend/src/composables/useIsMobile.ts	Switches window access to globalThis for matchMedia checks and subscriptions.
frontend/src/composables/useBackgroundMusicLoop.ts	Refactors/background-music lifecycle code formatting + uses globalThis for unlock events.
frontend/src/components/scene/SpritesLayer.vue	Refactors responsive sprite style selection for readability.
frontend/src/components/scene/NavBar.vue	Reflow trigger line adjusted to satisfy lint rule.
frontend/src/components/react/PearlShell.tsx	Refactors animation helpers + global access cleanup + PRNG change (see review comment re: int32 wrap semantics).
frontend/src/components/overlay/WhisperPanel.vue	Adjusts status colors.
frontend/src/components/overlay/TaskPanel.vue	Adjusts category/status colors.
frontend/src/components/overlay/MemoryPanel.vue	Adjusts error color.
frontend/src/components/overlay/CommunityPanel.vue	Adds alt attributes and tweaks some text color opacity.
frontend/src/components/overlay/ChatPanel.vue	Replaces type import with inline type reference.
frontend/src/components/overlay/CarPage.vue	Adds/adjusts alt attributes and improves form label/input associations; minor readability refactors.
frontend/src/components/overlay/BarPage.vue	Adds alt attributes and minor hashing change for determinism; color tweaks.
frontend/src/components/overlay/AuthPanel.vue	Adjusts error color.
frontend/src/components/overlay/AiMemoryPanel.vue	Adjusts category/error colors.
frontend/src/App.vue	Consolidates Vue imports ordering.
backend/internal/service/user.go	Extracts role-change validation helper and centralizes "id = ?" literal.
backend/internal/service/task_ai.go	Extracts chat-memory age-stage inference helper.
backend/internal/service/task.go	Minor signature cleanup.
backend/internal/service/echo.go	Centralizes trim whitespace characters constant in memoir text cleaning.
backend/internal/service/community.go	Extracts moderation/source validation helpers and centralizes error string constants.
backend/internal/service/chat.go	Extracts user-context resolution, improves context propagation, and factors fact parsing/saving helpers.
backend/internal/service/auth.go	Centralizes repeated auth error strings into constants.
backend/internal/router/router.go	Introduces Handlers struct to bundle route handler dependencies and centralizes repeated route fragments.
backend/internal/repository/chat.go	Minor signature cleanup.
backend/internal/handler/interaction.go	Deduplicates like handler logic via shared method (see review comment re: DELETE idempotency).
backend/internal/handler/auth.go	Clarifies why reset token is unused (avoids leaking token).
backend/cmd/server/main.go	Updates router setup call to pass *router.Handlers.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

[sonarqubecloud]

Quality Gate passed

Issues
14 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud