Conversation
cwpearson
force-pushed
the
ci/github-pr
branch
2 times, most recently
from
62d1477 to
e67f599
Compare
cwpearson
force-pushed
the
ci/github-pr
branch
from
e67f599 to
ade0355
Compare
cwpearson
force-pushed
the
ci/github-pr
branch
from
bfce071 to
f20433f
Compare
cwpearson
force-pushed
the
ci/github-pr
branch
from
2938d46 to
f48ca12
Compare
cwpearson
force-pushed
the
ci/github-pr
branch
from
a400b14 to
1ed5bf7
Compare
cedricchevalier19
left a comment
cedricchevalier19
left a comment
There was a problem hiding this comment.
I think it is a very good start.
In the future we can remove the scripts (with a global CMake #91). Perhaps these scripts can be relocated in a more hidden place?
The nightly should be run from Kokkos repo using workflow dispatch.
cwpearson
force-pushed
the
ci/github-pr
branch
from
b6f6f75 to
3600d67
Compare
cwpearson
force-pushed
the
ci/github-pr
branch
from
0ca2907 to
7a9c015
Compare
cwpearson
force-pushed
the
ci/github-pr
branch
from
4651bbf to
dbcc599
Compare
cedricchevalier19
left a comment
cedricchevalier19
left a comment
There was a problem hiding this comment.
I think we cannot run the proposed action while .github/workflows is empty.
@cwpearson, did you run the PR with a runner like https://github.com/nektos/act ?
|
If someone with rights can merge this, the next steps would probably be
|
masterleinad
left a comment
masterleinad
left a comment
There was a problem hiding this comment.
Looks good as a first step.
| cmake -S "${GITHUB_WORKSPACE}"/kokkos -B "${GITHUB_WORKSPACE}"/build-kokkos | ||
| -DCMAKE_INSTALL_PREFIX="${GITHUB_WORKSPACE}"/install-kokkos | ||
| -DCMAKE_CXX_COMPILER="${GITHUB_WORKSPACE}"/kokkos/bin/nvcc_wrapper | ||
| -DCMAKE_BUILD_TYPE=RelWithDebInfo |
There was a problem hiding this comment.
Fine but noting that it is the default hence unnecessary
| EXERCISES+=("$e"/Solution) | ||
| done | ||
|
|
||
| export Kokkos_ROOT="$kokkos_root" |
There was a problem hiding this comment.
Why do we handle Kokkos and KokkosKernels differently and why don't we just set these environment variable externally?
| backend="$6" | ||
|
|
||
| # These are exercises with CMakeLists.txt in Begin and Solution subdirectories | ||
| # TODO: advanced_reductions seems broken |
There was a problem hiding this comment.
Ah, Begin doesn't compile.
| # TODO: advanced_reductions seems broken | ||
| # TODO: hpcbind does not use cmake | ||
| # TODO: instances does not use cmake | ||
| # TODO: parallel_scan seems broken |
There was a problem hiding this comment.
It just means there were compilation errors when I tried to compile it in this framework. I didn't spend more than 30s looking at any of them. I figured fixing them up could be follow-on work.
Co-authored-by: Damien L-G <dalg24+github@gmail.com>
|
Is this okay to merge for now, and we can clean up more later? |
4 participants
Add PR tests a variety of exercises against Kokkos / Kokkos Kernels
masterbranches. This only builds the exercises, it does not run their solutions.Since it's a bit clumsy to build every exercise, this CI uses a script to do it (batch for Windows, bash for Linux/macOS).
Many exercises did not immediately build, have certain execution spaces hardcoded, or had other problems. Resolving those is left as future work.