Conversation
Co-authored-by: crtrott <9490481+crtrott@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add changes to strided_slice definition and headers
Add Feb 20, 2026
strided_slice updates with integral_constant_like support (P3663 piece 2 of N)
crtrott
reviewed
Feb 20, 2026
crtrott
reviewed
Feb 20, 2026
mhoemmen
approved these changes
Feb 20, 2026
| template<class OffsetType, class ExtentType, class StrideType> | ||
| void test_strided_slice(OffsetType offset, ExtentType extent, StrideType stride) | ||
| { | ||
| // Some compilers are bad at CTAD for aggregates. |
Contributor
There was a problem hiding this comment.
It would be nice if this worked! It's just that Clang is somehow bad at this.
Co-authored-by: Mark Hoemmen <mhoemmen@users.noreply.github.com>
crtrott
reviewed
Feb 20, 2026
crtrott
reviewed
Feb 20, 2026
crtrott
reviewed
Feb 20, 2026
crtrott
requested changes
Feb 20, 2026
Member
crtrott
left a comment
crtrott
left a comment
There was a problem hiding this comment.
The test can be unconditional. Nothing is protected by that macro.
…_strided_slice Co-authored-by: crtrott <9490481+crtrott@users.noreply.github.com>
crtrott
approved these changes
Feb 20, 2026
crtrott
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remove_cvref_tcontent to__p0009_bits/utility.hpp(instead of new header)__p2630_bits/integral_constant_like.hppwith equality_comparable backport + integral_constant_like content__p2630_bits/strided_slice.hppwith new type checks usingis_integral_constant_like_vtests/test_strided_slice.cpptests/CMakeLists.txtto include the new test#if defined(MDSPAN_IMPL_ENABLE_P3663)guards from test (test is now unconditional)operator()block and its comment frommy_integral_constant💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.