Macos workflow #303
Merged
Macos workflow #303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This could be revised later if a more modern version actually implements the feature correctly by checking the version value. Signed-off-by: Luc Berger-Vergiat <lberge@sandia.gov>
Since the test does not compile on MacOS and it is not really needed we are removing it. See discussion in issue kokkos#300. Signed-off-by: Luc Berger-Vergiat <lberge@sandia.gov>
…pleClang Signed-off-by: Luc Berger-Vergiat <lberge@sandia.gov>
Signed-off-by: Luc Berger-Vergiat <lberge@sandia.gov>
Signed-off-by: Luc Berger-Vergiat <lberge@sandia.gov>
Contributor
Author
|
After a few trial and errors, this seems to do the job pretty well : ) |
Contributor
|
Can't uou just do something like https://stackoverflow.com/a/78173242? or do you actually need change more than just the underlying runner OS? |
Contributor
Author
|
@masterleinad there are a few additional improvements made as you can see but we can revert to a more complicated and slower build option if you want? |
crtrott
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding an OSX CI workflow so that the work to get things working with AppleClang does not regress over time.