Skip to content

fix: remove duplicate SVG icons in hero visual cards#558

Merged
komalharshita merged 1 commit into
komalharshita:mainfrom
akhilmodi29:fix/duplicate-svg-icons-in-hero-cards
May 26, 2026
Merged

fix: remove duplicate SVG icons in hero visual cards#558
komalharshita merged 1 commit into
komalharshita:mainfrom
akhilmodi29:fix/duplicate-svg-icons-in-hero-cards

Conversation

@akhilmodi29
Copy link
Copy Markdown
Contributor

Fixes #557

Problem
The hero visual cards in templates/index.html had
duplicate SVG icons:

Blue card (Starter Code Ready):

  • Had 2 identical SVG icons stacked
  • First was a broken inline version
  • Second was the clean properly formatted version

Green card (7-Step Roadmap):

  • Had 3 identical SVG icons stacked
  • First and third were broken inline versions
  • Second was the clean properly formatted version

This caused:

  • Duplicate icons rendering in the hero section
  • Extra unnecessary DOM elements
  • Broken inline SVGs with incorrect formatting

Fix
Removed the duplicate broken SVG icons keeping only
the clean properly formatted version in each card.

Testing

  • Blue hero card shows single correct icon ✅
  • Green hero card shows single correct icon ✅
  • Hero section renders correctly ✅
  • No duplicate SVG elements in DOM ✅

@vercel
Copy link
Copy Markdown

vercel Bot commented May 25, 2026

@akhilmodi29 is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions Bot added gssoc-2026 type:bug Something isn't working type:accessibility ui and removed type:bug Something isn't working gssoc-2026 labels May 25, 2026
@akhilmodi29
Copy link
Copy Markdown
Contributor Author

@komalharshita Please review this PR and add the required labels including gssoc:approved. This fixes the duplicate SVG icons in hero visual cards.

Labels suggested:

  • level:beginner
  • type:bug
  • quality:clean

Copy link
Copy Markdown
Owner

@komalharshita komalharshita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch — this is a clean and well-scoped fix.

The PR correctly removes duplicated SVG elements from the hero visual cards while preserving the intended UI appearance. The cleanup also reduces unnecessary DOM duplication and improves markup consistency.

Tested scope is minimal and safe, with no unintended logic changes observed.

Approved for merge.

@komalharshita komalharshita merged commit 81f6892 into komalharshita:main May 26, 2026
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] index.html - Duplicate SVG icons in hero visual cards cause extra DOM elements

2 participants