Skip to content

Redirection links fixed#70

Merged
komalharshita merged 4 commits into
komalharshita:mainfrom
Lalitya31:gitlink
May 17, 2026
Merged

Redirection links fixed#70
komalharshita merged 4 commits into
komalharshita:mainfrom
Lalitya31:gitlink

Conversation

@Lalitya31
Copy link
Copy Markdown
Contributor

Summary [required]

  • Designing and integrating proper routing for the “About Us / Our Story” section
  • Refactoring existing footer link configurations and navigation mappings
  • Updating repository redirect paths to ensure all GitHub references point to the correct project resources.
  • Streamlining footer interactions to maintain consistent navigation behavior across the platform

Related Issue [required]

Closes #45

Type of Change [required]

  • Bug fix — resolves a broken behaviour
  • Feature — adds new functionality
  • Data — adds new projects to data/projects.json
  • Documentation — updates docs, README, or code comments only
  • Style — CSS or visual changes only, no logic change
  • Refactor — restructures code without changing behaviour
  • Test — adds or updates tests

What Was Changed [required]

File Change made
templates/index.html Added github link to the project repository
templates/project.html Added syncronized navigations to each link , elements

How to Test This PR [required]

  1. Clone this branch: git checkout gitlink
  2. Install dependencies: pip install -r requirements.txt
  3. Run the app: python app.py
  4. Open http://127.0.0.1:5000 and...
  5. Run the tests: python tests/test_basic.py

Test Results [required]

redirection to pages works

Self-Review Checklist [required]

  • I have read CONTRIBUTING.md and followed all guidelines
  • My branch name follows the convention: feat/, fix/, docs/, data/, style/, test/
  • I have run python tests/test_basic.py and all 27 tests pass
  • I have run flake8 . locally and there are no errors
  • I have not introduced any print() or console.log() debug statements
  • Every new function I wrote has a docstring
  • I have not modified files outside the scope of the linked issue
  • If I changed the UI, I tested it at 375px (mobile) and 1280px (desktop)
  • If I added a project to the dataset, it has all required JSON fields

Notes for Reviewer

None

Copilot AI review requested due to automatic review settings May 15, 2026 06:39
@vercel
Copy link
Copy Markdown

vercel Bot commented May 15, 2026

@Lalitya31 is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting your first pull request to DevPath.

Before review:

  • Complete the PR template fully
  • Ensure all tests pass
  • Link your PR to an issue
  • Keep changes scoped to the issue

A maintainer will review your contribution soon.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses broken footer/navigation GitHub redirections and adds an in-page “Our Story / About Us” section on the homepage to prevent “About Us / Our Story” from incorrectly linking out to GitHub.

Changes:

  • Updated GitHub links in the homepage and project detail templates to point to the DevPath repository (and related resources like issues/CONTRIBUTING/LICENSE).
  • Added an “Our Story / About Us” section on the homepage and wired footer links to the #our-story anchor.
  • Added a package-lock.json file to the repository.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.

File Description
templates/project.html Updates header/footer GitHub links away from https://github.com to the project repository.
templates/index.html Updates GitHub/resource links and adds an “Our Story” section with footer navigation to #our-story.
package-lock.json Introduces an npm lockfile (currently without a corresponding package.json).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread templates/index.html
Comment thread templates/project.html
@Lalitya31
Copy link
Copy Markdown
Contributor Author

@komalharshita this PR is ready for review and merge since 2 days. Thank you :)

Copy link
Copy Markdown
Owner

@komalharshita komalharshita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution — the navigation fixes and “Our Story” section are well implemented and improve the UX significantly.

The GitHub/resource redirects are now correctly scoped to the repository, and the footer navigation behavior is much more consistent across pages.

Before merge, there is one important cleanup required:

Requested Change

Please remove the package-lock.json file from this PR.

The repository currently does not appear to use npm/package-based tooling, and this file is unrelated to the linked issue. Keeping the PR scoped only to the routing/navigation fixes will make the contribution cleaner and easier to maintain.

Once that file is removed, this PR should be ready for approval.

@Lalitya31
Copy link
Copy Markdown
Contributor Author

@komalharshita Removed the unrelated package-lock.json

@komalharshita
Copy link
Copy Markdown
Owner

@Lalitya31 kindly resolve the merge conflicts

@komalharshita komalharshita added the need review Further information is requested label May 17, 2026
@Lalitya31
Copy link
Copy Markdown
Contributor Author

@komalharshita resolved. i hope no issues now

@komalharshita
Copy link
Copy Markdown
Owner

approved for merge

@komalharshita komalharshita merged commit 42d916b into komalharshita:main May 17, 2026
7 of 8 checks passed
@komalharshita komalharshita removed the need review Further information is requested label May 17, 2026
@Lalitya31 Lalitya31 deleted the gitlink branch May 18, 2026 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Github links

3 participants