Skip to content

[codex] Add manual timer API for tests#216

Merged
Bathtor merged 5 commits intokompics:masterfrom
Bathtor:manual-test-timer-api
Apr 11, 2026
Merged

[codex] Add manual timer API for tests#216
Bathtor merged 5 commits intokompics:masterfrom
Bathtor:manual-test-timer-api

Conversation

@Bathtor
Copy link
Copy Markdown
Contributor

@Bathtor Bathtor commented Apr 11, 2026

What changed

  • add a manually-driven timer API for deterministic tests
  • expose the timer-backed current time through KompactSystem::now() and SystemHandle::now()
  • add install_manual_timer and a regression test that proves timers do not fire until explicitly advanced
  • update the timer dependency requirement to the 1.4 series needed for the manual timer API

Why

The vendored kompact-0.11.3 changes add support for deterministic timer-driven tests. This ports that behaviour into the workspace layout used in the upstream repository.

Validation

  • cargo test -p kompact installed_manual_timer_requires_explicit_advance --quiet

@Bathtor
Copy link
Copy Markdown
Contributor Author

Bathtor commented Apr 11, 2026

@codex review

1 similar comment
@Bathtor
Copy link
Copy Markdown
Contributor Author

Bathtor commented Apr 11, 2026

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Nice work!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Bathtor Bathtor marked this pull request as ready for review April 11, 2026 19:04
@Bathtor Bathtor merged commit 493f2fe into kompics:master Apr 11, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant