Skip to content
This repository was archived by the owner on Nov 27, 2024. It is now read-only.

add kube-linter checks#214

Merged
openshift-merge-bot[bot] merged 12 commits intokonflux-workspaces:mainfrom
sadlerap:kube-linter
Jun 28, 2024
Merged

add kube-linter checks#214
openshift-merge-bot[bot] merged 12 commits intokonflux-workspaces:mainfrom
sadlerap:kube-linter

Conversation

@sadlerap
Copy link
Member

Infra-deployments has a suite of checks that makes sure every kustomize manifest committed passes kube-linter in its default configuration. If we want to release onto platforms supported by infra-deployments, we need to be able to pass these checks too.

This introduces a new check in CI to ensure that we don't fall out-of-line with what infra-deployments expects.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Copy link
Member

@filariow filariow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, just some nits

sadlerap added 10 commits June 26, 2024 12:24
Infra-deployments has a suite of checks that makes sure every kustomize
manifest committed passes kube-linter in its default configuration.  If
we want to release onto platforms supported by infra-deployments, we
need to be able to pass these checks too.

This introduces a new check in CI to ensure that we don't fall
out-of-line with what infra-deployments expects.

Signed-off-by: Andy Sadler <ansadler@redhat.com>
Rather than pre-commit our image tags (which will likely get out-of-date
very quickly), add in references to the built images during the
packaging process.

Signed-off-by: Andy Sadler <ansadler@redhat.com>
Signed-off-by: Andy Sadler <ansadler@redhat.com>
Signed-off-by: Andy Sadler <ansadler@redhat.com>
this information is already captured in github's security report, so it
doesn't add anything useful.

Signed-off-by: Andy Sadler <ansadler@redhat.com>
Signed-off-by: Andy Sadler <ansadler@redhat.com>
this was a debugging change that shouldn't have been committed

Signed-off-by: Andy Sadler <ansadler@redhat.com>
sadlerap added 2 commits June 27, 2024 09:51
Signed-off-by: Andy Sadler <ansadler@redhat.com>
don't know how that snuck in

Signed-off-by: Andy Sadler <ansadler@redhat.com>
@sadlerap sadlerap requested a review from filariow June 28, 2024 14:14
@openshift-ci openshift-ci bot added the lgtm label Jun 28, 2024
@openshift-ci
Copy link

openshift-ci bot commented Jun 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: filariow, sadlerap

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 183780f into konflux-workspaces:main Jun 28, 2024
@sadlerap sadlerap deleted the kube-linter branch June 28, 2024 14:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants