Skip to content
This repository was archived by the owner on Nov 27, 2024. It is now read-only.

e2e: allow overriding deployment/testing namespace#217

Merged
openshift-merge-bot[bot] merged 1 commit intokonflux-workspaces:mainfrom
sadlerap:e2e-override-namespace
Jun 26, 2024
Merged

e2e: allow overriding deployment/testing namespace#217
openshift-merge-bot[bot] merged 1 commit intokonflux-workspaces:mainfrom
sadlerap:e2e-override-namespace

Conversation

@sadlerap
Copy link
Member

In some circumstances, we may want to deploy and run e2e tests in a namespace that isn't "workspaces-system". This wires up the necessary infrastructure into e2e to do so.

Copy link
Member

@filariow filariow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's just remove pushd and popd as they are not POSIX compatible

In some circumstances, we may want to deploy and run e2e tests in a
namespace that isn't "workspaces-system".  This wires up the necessary
infrastructure into e2e to do so.

Signed-off-by: Andy Sadler <ansadler@redhat.com>
@sadlerap sadlerap requested a review from filariow June 26, 2024 15:20
Copy link
Member

@filariow filariow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jun 26, 2024
@openshift-ci
Copy link

openshift-ci bot commented Jun 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: filariow, sadlerap

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 26be15f into konflux-workspaces:main Jun 26, 2024
@sadlerap sadlerap deleted the e2e-override-namespace branch June 26, 2024 16:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants