add book's Development section#222
add book's Development section#222openshift-merge-bot[bot] merged 1 commit intokonflux-workspaces:mainfrom
Conversation
Signed-off-by: Francesco Ilario <filario@redhat.com>
| # the quay.io namespace to use in the next steps | ||
| export QUAY_NAMESPACE=my-quay-namespace | ||
| ``` | ||
|
|
There was a problem hiding this comment.
Maybe call out the IMAGE_BUILDER env var?
There was a problem hiding this comment.
good idea, I'll do this a new PR
|
|
||
| ## Run Tests | ||
|
|
||
| To run Unit tests you can execute the `make test` command. |
There was a problem hiding this comment.
| To run Unit tests you can execute the `make test` command. | |
| To run unit tests you can execute the `make test` command. |
|
|
||
| ## Run Tests | ||
|
|
||
| To run Unit tests you can execute the `make test` command. |
There was a problem hiding this comment.
| To run Unit tests you can execute the `make test` command. | |
| To run unit tests you can execute the `make test` command. |
Also, it's at this point that I realize we should probably have a top-level unit-test rule that runs all unit tests. IMO there's not any real good reason that unit tests shouldn't run everything.
There was a problem hiding this comment.
typo fixed in #224.
I agree on the top level unit-test rule. I'll open a PR for this.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dperaza4dustbit, filariow The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 participants
Signed-off-by: Francesco Ilario filario@redhat.com