This repository was archived by the owner on Nov 27, 2024. It is now read-only.
book: fix typos#229
Merged
openshift-merge-bot[bot] merged 2 commits intokonflux-workspaces:mainfrom Jul 9, 2024
Merged
Conversation
doc/book/src/operator/workflows.md
Outdated
| @@ -5,19 +5,19 @@ In this section are detailed the main workflow implemented by this operator. | |||
| ## Home Workspace | |||
|
|
|||
| When an [KubeSaw](https://github.com/codeready-toolchain) UserSignup is approved, a Space is created by default. | |||
Contributor
There was a problem hiding this comment.
When an KubeSaw UserSignup --> When a KubeSaw UserSignup
doc/book/src/operator/workflows.md
Outdated
|
|
||
| When an [KubeSaw](https://github.com/codeready-toolchain) UserSignup is approved, a Space is created by default. | ||
| This workflow monitors ensures an InternalWorkspace exists for the Space. | ||
| The operator ensures an InternalWorkspace exists for the user's default Space. |
Contributor
There was a problem hiding this comment.
"Operator" is more generic term, "controller" might be better here
doc/book/src/operator/workflows.md
Outdated
| A `community` InternalWorkspace is visible by every authenticated users. | ||
|
|
||
| If an InternalWorkspace visibility is set to `community`, the operator makes sure that a SpaceBinding exists for the special-user `kubesaw-authenticated`, the space related to the InternalWorkspace, and the role `viewer`. | ||
| If the visibility is set to `private`, the SpaceBinding is ensured not to exist. |
Contributor
There was a problem hiding this comment.
the SpaceBinding is removed
Signed-off-by: Francesco Ilario <filario@redhat.com>
Signed-off-by: Francesco Ilario <filario@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dperaza4dustbit, filariow The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Francesco Ilario filario@redhat.com