Skip to content
This repository was archived by the owner on Nov 27, 2024. It is now read-only.

fix shellcheck CI configuration#27

Merged
filariow merged 1 commit intokonflux-workspaces:mainfrom
sadlerap:shellcheck
Mar 8, 2024
Merged

fix shellcheck CI configuration#27
filariow merged 1 commit intokonflux-workspaces:mainfrom
sadlerap:shellcheck

Conversation

@sadlerap
Copy link
Member

@sadlerap sadlerap commented Mar 8, 2024

We should run this as a part of security checks, not as a part of CI for server/ changes.

We should run this as a part of security checks, not as a part of CI for
`server/` changes.

Signed-off-by: Andy Sadler <ansadler@redhat.com>
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@sadlerap sadlerap requested a review from filariow March 8, 2024 21:14
Copy link
Member

@filariow filariow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@filariow filariow merged commit 5418582 into konflux-workspaces:main Mar 8, 2024
@sadlerap sadlerap deleted the shellcheck branch March 8, 2024 21:35
filariow pushed a commit to filariow/workspaces that referenced this pull request Mar 9, 2024
We should run this as a part of security checks, not as a part of CI for
`server/` changes.

Signed-off-by: Andy Sadler <ansadler@redhat.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants