This repository was archived by the owner on Nov 27, 2024. It is now read-only.
smoke: fix writing log file#281
Merged
openshift-merge-bot[bot] merged 1 commit intokonflux-workspaces:mainfrom Aug 30, 2024
sadlerap:smoke-log-file
Merged
smoke: fix writing log file#281openshift-merge-bot[bot] merged 1 commit intokonflux-workspaces:mainfrom sadlerap:smoke-log-file
openshift-merge-bot[bot] merged 1 commit intokonflux-workspaces:mainfrom
sadlerap:smoke-log-file
Conversation
We were writing the log file to "${RESPONSE}", not "${LOG_FILE}", which
made for invalid file names.
Signed-off-by: Andy Sadler <ansadler@redhat.com>
filariow
approved these changes
Aug 30, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: filariow, sadlerap The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were writing the log file to "${RESPONSE}", not "${LOG_FILE}", which made for invalid file names.