This repository was archived by the owner on Nov 27, 2024. It is now read-only.
operator: don't generate data field for metrics-reader secret#294
Merged
openshift-merge-bot[bot] merged 1 commit intokonflux-workspaces:mainfrom Sep 13, 2024
sadlerap:no-secret-generation
Merged
operator: don't generate data field for metrics-reader secret#294openshift-merge-bot[bot] merged 1 commit intokonflux-workspaces:mainfrom sadlerap:no-secret-generation
openshift-merge-bot[bot] merged 1 commit intokonflux-workspaces:mainfrom
sadlerap:no-secret-generation
Conversation
ArgoCD gets thrown into an out-of-sync loop when the data field exists on the metrics-reader secret. This is because the service account controller fills in the data field with all the information a service account secret needs, which conflicts with the empty data that ArgoCD expects. This data field exists because kustomize's secret generator provides a data field by default, and it appears there isn't a way to disable this. To resolve this, we need to move away from using the secret generator in our kustomization manifests and instead spell out the secret in our manifests directly. Signed-off-by: Andy Sadler <ansadler@redhat.com>
filariow
approved these changes
Sep 13, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: filariow, sadlerap The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ArgoCD gets thrown into an out-of-sync loop when the data field exists on the metrics-reader secret. This is because the service account controller fills in the data field with all the information a service account secret needs, which conflicts with the empty data that ArgoCD expects. This data field exists because kustomize's secret generator provides a data field by default, and it appears there isn't a way to disable this.
To resolve this, we need to move away from using the secret generator in our kustomization manifests and instead spell out the secret in our manifests directly.