This repository was archived by the owner on Nov 27, 2024. It is now read-only.
add TargetCluster URL in InternalWorkspace's status#304
Merged
openshift-merge-bot[bot] merged 7 commits intokonflux-workspaces:mainfrom Oct 9, 2024
Merged
add TargetCluster URL in InternalWorkspace's status#304openshift-merge-bot[bot] merged 7 commits intokonflux-workspaces:mainfrom
openshift-merge-bot[bot] merged 7 commits intokonflux-workspaces:mainfrom
Conversation
Member
Author
|
/hold |
sadlerap
previously approved these changes
Sep 27, 2024
filariow
force-pushed
the
workspace-url
branch
4 times, most recently
from
956071e to
41b1c6e
Compare
filariow
commented
Oct 4, 2024
This commit adds a test case for checking the behavior of the system when an user with a long name (>20 characters) onboards Signed-off-by: Francesco Ilario <filario@redhat.com>
Signed-off-by: Francesco Ilario <filario@redhat.com>
Signed-off-by: Francesco Ilario <filario@redhat.com>
Signed-off-by: Francesco Ilario <filario@redhat.com>
Signed-off-by: Francesco Ilario <filario@redhat.com>
filariow
force-pushed
the
workspace-url
branch
from
0ca2f5d to
2261fd5
Compare
filariow
commented
Oct 7, 2024
sadlerap
previously approved these changes
Oct 7, 2024
Member
|
/hold |
Member
|
With those changes you've suggested, lgtm |
Signed-off-by: Francesco Ilario <filario@redhat.com>
sadlerap
approved these changes
Oct 9, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: filariow, sadlerap The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
Author
|
/unhold |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
requires #308