This repository was archived by the owner on Nov 27, 2024. It is now read-only.
vendor yq#45
Merged
filariow merged 1 commit intokonflux-workspaces:mainfrom Mar 22, 2024
sadlerap:yq-cmd
Merged
Conversation
filariow
approved these changes
Mar 22, 2024
| MOCKGEN ?= $(BIN_FOLDER)/mockgen | ||
| GOLANG_CI ?= go run -modfile $(shell dirname $(ROOT_DIR))/hack/tools/golang-ci/go.mod github.com/golangci/golangci-lint/cmd/golangci-lint | ||
| YQ ?= $(BIN_FOLDER)/yq | ||
| GOLANG_CI ?= $(GO) run -modfile $(shell dirname $(ROOT_DIR))/hack/tools/golang-ci/go.mod github.com/golangci/golangci-lint/cmd/golangci-lint |
Member
There was a problem hiding this comment.
as tools are getting more and more it may be valuable introducing a new variable TOOLS_DIR set to $(shell dirname $(ROOT_DIR))/hack/tools
Member
Author
There was a problem hiding this comment.
I'll add that in a separate PR; I've got another tool to vendor (operator-sdk, needed for the stuff under operator/) and I'll make that change in that PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.