This repository was archived by the owner on Nov 27, 2024. It is now read-only.
cd: build/push images#59
Merged
filariow merged 5 commits intokonflux-workspaces:mainfrom Apr 4, 2024
sadlerap:cd-build-images
Merged
cd: build/push images#59filariow merged 5 commits intokonflux-workspaces:mainfrom sadlerap:cd-build-images
filariow merged 5 commits intokonflux-workspaces:mainfrom
sadlerap:cd-build-images
Conversation
Push built artifacts to quay.io for further distribution, either for
testing or use in production.
Containers are tagged under the following naming convention:
- Release artifacts are tagged with the output of `git describe
--always`. The most-recently-pushed container will be tagged with
`latest`.
- Testing artifacts are tagged as `pr-${PR_NUMBER}-${COMMIT}`, where
$PR_NUMBER is the pull request number, and $COMMIT is the output of
`git describe --always` on the latest commit. This naming convention
distinguishes testing artifacts from release artifacts.
Signed-off-by: Andy Sadler <ansadler@redhat.com>
Co-authored-by: Francesco Ilario <filario@redhat.com> Signed-off-by: Andy Sadler <ansadler@redhat.com>
This makes image tags more predictable and will let us pull pre-built images in prow. Signed-off-by: Andy Sadler <ansadler@redhat.com>
filariow
reviewed
Apr 4, 2024
filariow
reviewed
Apr 4, 2024
Fix three errors: - we should unconditionally use $GITHUB_SHA for fetching commit SHAs, rather than from the pull_request event. - remove an outdated comment referring to ghcr.io; we don't push there. - `docker push -a` takes an untagged image name, so we should leave them off. Signed-off-by: Andy Sadler <ansadler@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Push built artifacts to quay.io for further distribution, either for testing or use in production.
Containers are tagged under the following naming convention:
latest.pr-${PR_NUMBER}-${COMMIT}, where $PR_NUMBER is the pull request number, and $COMMIT is the first 8 characters on the latest commit. This naming convention distinguishes testing artifacts from release artifacts.