Skip to content
This repository was archived by the owner on Nov 27, 2024. It is now read-only.

fix image builds in CI#64

Merged
sadlerap merged 1 commit intokonflux-workspaces:mainfrom
sadlerap:fix-image-builds
Apr 8, 2024
Merged

fix image builds in CI#64
sadlerap merged 1 commit intokonflux-workspaces:mainfrom
sadlerap:fix-image-builds

Conversation

@sadlerap
Copy link
Member

@sadlerap sadlerap commented Apr 8, 2024

No description provided.

@sadlerap sadlerap requested a review from filariow April 8, 2024 19:49
filariow
filariow previously approved these changes Apr 8, 2024
Copy link
Member

@filariow filariow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Andy Sadler <ansadler@redhat.com>
@sadlerap
Copy link
Member Author

sadlerap commented Apr 8, 2024

Realized the change I made in ee3e833 was a mistake, so had to revert it. It would've caused build failures once we had merged this.

@sadlerap sadlerap merged commit d3d7a25 into konflux-workspaces:main Apr 8, 2024
@sadlerap
Copy link
Member Author

sadlerap commented Apr 8, 2024

Hmm, it appears we're still tagging images incorrectly when we build production images. I'll take a look tomorrow and see what's going on.

@sadlerap sadlerap deleted the fix-image-builds branch April 9, 2024 13:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants