fix: ka icon — dark background so letters are actually visible#9
Merged
Conversation
Background was the same accent blue as the letters — at small sizes (16-32 px taskbar) the icon rendered as a featureless blue square. Switch to dark bg (rgb 12,12,18) with accent-blue letters (99,155,255), bump canvas to 64 px, and tighten the opening angle on the a-bowl so both glyphs read cleanly at all Windows icon sizes.
…parent interior Both smoothstep calls had edge0/edge1 reversed: - smoothstep(0.7, -0.7, bg_d) returned 0 inside the rounded rect (transparent) and 1 outside (opaque corners) — completely backwards. - smoothstep(sw+0.7, sw-0.7, dist) returned 0 on stroke centers and 1 far from strokes — letters were invisible on the background. Result was a blank white square in every Windows context. Fix: smoothstep(-0.7, 0.7, bg_d) and smoothstep(sw-0.7, sw+0.7, dist) in both icon.rs and build.rs. Also switch build.rs exe icon to the same dark-bg + accent-blue style, and add 24/64 px to the ico size table.
Previous ka_alpha had sw=11.5% of size causing the 'a' bowl's stroke extent to overlap the K arm by ~3px at 64px and worse at smaller sizes. Letters visually merged into an unreadable blob. New design uses sw=6.2% with analytically verified 2px gap at 64px and flush-but-non-overlapping at 32px. The 'a' uses a simpler open-circle bowl (angle < 0.28 rad opening) + full-height stem tangent to the bowl.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The icon background and the letter fill were both in the same accent-blue family. At 16–32 px (Windows taskbar), they blended into a featureless blue square — no letters visible.
Fix
rgb(12, 12, 18)rgb(99, 155, 255)a-bowl opening angle tightened to 0.42 rad so the bowl reads clearly as "a" at small sizes