fix: force replace Job during a sync#792
Merged
muse-sisay merged 2 commits intokonstructio:mainfrom Aug 21, 2024
Merged
Conversation
A Job resource is an immutable resource. Changes to spec.template causes a sync error. Add annotation to force replaces Job resources. Remove the sync option "replace" from vault-wait ArgoCD app and add to the Job resource as SA and CRB resources do not need to be replaced.
CristhianF7
approved these changes
Aug 21, 2024
Contributor
|
let's get this fix into the other stacks too. don't care if that's this pr or a follow up one. awesome quick find and fix @muse-sisay thank you! 🚀 |
Note K3d and k3s are missing vault-wait app.
Contributor
Author
|
Added changes to all other stacks except to K3d and k3s, as they are missing vault-wait app. |
patrickdappollonio
approved these changes
Aug 21, 2024
johndietz
approved these changes
Aug 21, 2024
jokestax
pushed a commit
that referenced
this pull request
Sep 3, 2024
* fix: force replace Job during a sync A Job resource is an immutable resource. Changes to spec.template causes a sync error. Add annotation to force replaces Job resources. Remove the sync option "replace" from vault-wait ArgoCD app and add to the Job resource as SA and CRB resources do not need to be replaced.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A Job resource is an immutable resource. Changes to spec.template causes a sync error. Add annotation to force replaces Job resources.
Remove the sync option "replace" from vault-wait ArgoCD app and add to the Job resource as SA and CRB resources do not need to be replaced.
Related Issue(s)
konstructio/kubefirst#2264
How to test
Provision a management cluster and verify
vault-waitjob is healthy.