fix(azure): update argo workflows to store artifacts correctly#835
Merged
mrsimonemms merged 1 commit intomainfrom Nov 27, 2024
Merged
fix(azure): update argo workflows to store artifacts correctly#835mrsimonemms merged 1 commit intomainfrom
mrsimonemms merged 1 commit intomainfrom
Conversation
Contributor
|
Hey @mrsimonemms ,do we have logic to detokenize <KUBEFIRST_STATE_STORE_CONTAINER_NAME> in api? |
Contributor
Author
|
jokestax
approved these changes
Nov 27, 2024
Contributor
|
cool 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates the Argo workflow configuration is done so that the artifacts are stored correctly. The storage container uses credentials from the ChartMuseum Vault secret.
This now publishes the Metaphor app to the cluster:
I've added Reload annotations to the server and controller for the configmap and secrets used to reload the pods if the configmap and secret changes - if there's an already workflow, this doesn't affect it as they're run as separate jobs (but it would likely fail anyway as the configuration has changed).
Related Issue(s)
Fixes #
How to test
Deploy an Azure app and watch Metaphor run. I have demos if you want to pair