Skip to content

fix: pin gke and dependencies versions#849

Merged
jokestax merged 3 commits intomainfrom
fix-gke-version
Jan 9, 2025
Merged

fix: pin gke and dependencies versions#849
jokestax merged 3 commits intomainfrom
fix-gke-version

Conversation

@jokestax
Copy link
Copy Markdown
Contributor

@jokestax jokestax commented Jan 1, 2025

Description

Updated Terraform modules to resolve provider version conflicts:

  • VPC module to 10.0.0
  • Cloud NAT module to 5.3.0

Before Updating
Before Update 1
Before Update 2
Before Update 3

After Updating
After Update 1
After Update 2
After Update 3

Testing

Provision Google management with the flag --gitops-template-branch fix-gke-version
Example:

kubefirst google create \  
  --alerts-email 1@gmail.com \  
  --domain-name kuberfu.com \  
  --dns-provider cloudflare \  
  --gitops-template-branch fix-gke-version \  
  --git-provider github \  
  --github-org ar6464 \  
  --cluster-name rr19 \  
  --google-project <project-name>

@jokestax jokestax changed the title Fix gke version fix: gke and dependencies versions Jan 1, 2025
@jokestax jokestax changed the title fix: gke and dependencies versions fix: pin gke and dependencies versions Jan 1, 2025
@jokestax jokestax self-assigned this Jan 1, 2025
@jokestax jokestax added the bug Something isn't working label Jan 1, 2025
Copy link
Copy Markdown

@patrickdappollonio patrickdappollonio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we want to hard pin the versions to specific ones. I would think a version "range" of anything within major and minor should suffice (I saw in the past we had just major, but considering minor versions could have some breaking changes, I wouldn't risk it).

Can we do it in ranges? For example for the cloud-nat module, I would prefer ~> 5.3 rather than hardcoding to 5.3.0.

Comment thread google-github/terraform/google/gke/nat.tf Outdated
Comment thread google-github/terraform/google/vpc.tf Outdated
Comment thread google-gitlab/terraform/google/gke/nat.tf Outdated
Copy link
Copy Markdown
Contributor

@mrsimonemms mrsimonemms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm in agreement with @patrickdappollonio on this and would prefer to see a range dependency used. If there is a minimum requirement on a specific version for something, you can keep the range but bump the min version.

If there is a reason this won't work, please explain it so I can understand it.

Comment thread google-gitlab/terraform/google/gke/nat.tf Outdated
Comment thread google-github/terraform/google/vpc.tf Outdated
Comment thread google-github/terraform/google/gke/nat.tf Outdated
Comment thread google-gitlab/terraform/google/vpc.tf Outdated
Co-authored-by: Simon Emms <simon@simonemms.com>
@jokestax jokestax requested a review from mrsimonemms January 9, 2025 16:02
@jokestax
Copy link
Copy Markdown
Contributor Author

jokestax commented Jan 9, 2025

@mrsimonemms @patrickdappollonio,i have applied according changes can i get a ✅ :)

@mrsimonemms mrsimonemms dismissed patrickdappollonio’s stale review January 9, 2025 16:29

Requested changes made

@jokestax jokestax merged commit d71c1fe into main Jan 9, 2025
@jokestax jokestax deleted the fix-gke-version branch January 9, 2025 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants