🐛 fix: resolve ButtonGroup first item missing left border#517
Merged
Conversation
The animated pill <motion.div> was rendered as the first child inside the radiogroup container, causing Tailwind's first:/last: pseudo-selectors to target the pill instead of the first button. Replace CSS pseudo-selectors with explicit isFirst/isLast CVA variants computed from the item index.
futjesus
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<motion.div>was rendered as the first child inside the radiogroup container, causing Tailwind'sfirst:/last:pseudo-selectors to target the pill instead of the first buttonfirst:border-l,first:rounded-l-lg,last:border-r,last:rounded-r-lgCSS pseudo-selectors with explicitisFirst/isLastCVA variants computed from the item indexisFirstandisLastboolean props toButtonGroupItemTest plan
npm run check:types— no type errorsnpm run lint— no lint errorsnpm run test— all 394 tests pass