🔒 security: disable postinstall scripts with trusted allowlist#625
Merged
🔒 security: disable postinstall scripts with trusted allowlist#625
Conversation
Set ignore-scripts=true in .npmrc to block arbitrary postinstall execution from dependencies, and expose an npm run setup allowlist (esbuild, husky) for the scripts the project actually needs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ignore-scripts=trueto.npmrcso npm stops running postinstall scripts from dependencies automatically — mitigates the recent wave of compromised/malicious npm packages that abuse install-time hooks.setupnpm script as the explicit allowlist for packages this project does need to build:npm rebuild esbuild(Vite's native binary) andhusky(git hooks via the rootpreparescript, which is also blocked byignore-scripts).CLAUDE.mdunder a new Security section.Test plan
rm -rf node_modules && npm installcompletes without executing dependency postinstall scripts.npm run setuprebuildsesbuildand installs husky git hooks successfully.npm run buildsucceeds afternpm run setup(verifies esbuild binary is usable).git committriggers husky hooks (verifies husky was installed).