-
Notifications
You must be signed in to change notification settings - Fork 36
Rebranding #101
Conversation
✅ Deploy Preview for kontent-sample-app-vue ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Notes:
- package.json - rename name of the packages (remove
kontent-from package name) - Remove GT-Walfheim and use OS font from the guide
- (optional) take a look to packages (try at least minor versions bump)
Great work with the Store rewrite! 👍🏼
|
Upgrade will be done in #102 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Let's unify the configuration page with new visuals (logo colors)
- Add redirects to netlify: https://github.com/kontent-ai/sample-app-react/blob/master/netlify.toml
- Try to unify font to WorkSans - if something does not look OK - try to adjust font-weight
- Coffees filter does not work
- Brewers filter is missing
- I don't se subtitle on Home hero banner, Titles on Latest articles
- Rich text resolution for twitter widget and video is not resolved
~/en-us/articles/cf106f4e-30a4-42ef-b313-b8ea3fd3e5c5
Simply007
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If i go to some page and back - i don't see the cafes:
If I go to https://deploy-preview-101--kontent-sample-app-vue.netlify.app/es-ES/articles/117cdfae-52cf-4885-b271-66aef6825612 (ES language) the link in text does not preserve nor load currect language varian of the coffee (link is https://deploy-preview-101--kontent-sample-app-vue.netlify.app/coffees/kenya-gakuyuni-aa)
|
I agree with the first one, there was one additional condition which made this error. The second one might be due to fallbacking into English language due to not published content in ES language. |
In that case, there should be ˙https://deploy-preview-101--kontent-sample-app-vue.netlify.app/en-US/coffees/kenya-gakuyuni-aa˙ (with language codename right). The thing is we don't want to have the same content on different URLs. Not sure about the fallback - If we want to change the language prefix or keep it - but some should be present. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything, but language behavior is fine.
- lowercase language prefixes
- default route should enforce prefix
/articles->/en-us/articles - If a fallback is used enforce the fallback language right to the prefix and basically change it
- Describe the behavior in the README -> at least brief - to be ready
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Homepage link for About us has a "More Articles" label.
Haven't found anything more.
Simply007
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update the readme to reflect the current state.
406789f to
c7fb0bc
Compare
|
I have updated the readme. Added a new paragraph about data fetching with an example, fixed grammar mistakes, and adjusted the structure of the whole readme |
Simply007
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on README.
I have one comment about configuration + I might change the name of the kk-logo.svg to something more accurate.
Motivation
Which issue does this fix? Fixes #
issue numberMigration and rebranding
Checklist
How to test
If manual testing is required, what are the steps?