-
Notifications
You must be signed in to change notification settings - Fork 103
fix: enhance project configuration with dynamic versioning and update CI workflow for artifact handling #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: enhance project configuration with dynamic versioning and update CI workflow for artifact handling #36
Conversation
… CI workflow for artifact handling
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
.github/workflows/python-publish.yml:34
- Verify that the 'uv build' command generates both the wheel and sdist artifacts as expected. If it does not, adjust the command to explicitly build both distributions to ensure consistency with downstream steps.
run: uv build
pyproject.toml:88
- [nitpick] Ensure that automatic version bumping with 'bump = true' aligns with your release process, as it might lead to unintended version increments if not managed carefully.
bump = true
🦙 MegaLinter status:
|
| Descriptor | Linter | Files | Fixed | Errors | Elapsed time |
|---|---|---|---|---|---|
| ✅ ACTION | actionlint | 2 | 0 | 0.02s | |
| jscpd | yes | 2 | 1.39s | ||
| hadolint | 1 | 1 | 0.18s | ||
| ✅ JSON | jsonlint | 1 | 0 | 0.2s | |
| ✅ JSON | prettier | 1 | 1 | 0 | 0.39s |
| ✅ JSON | v8r | 1 | 0 | 3.15s | |
| ✅ PYTHON | bandit | 5 | 0 | 0.76s | |
| ✅ PYTHON | black | 5 | 0 | 0 | 0.71s |
| ✅ PYTHON | flake8 | 5 | 0 | 0.4s | |
| ✅ PYTHON | isort | 5 | 1 | 0 | 0.17s |
| ✅ PYTHON | mypy | 5 | 0 | 2.96s | |
| ✅ PYTHON | pylint | 5 | 0 | 5.76s | |
| ✅ PYTHON | pyright | 5 | 0 | 4.93s | |
| ✅ PYTHON | ruff | 5 | 1 | 0 | 0.02s |
| checkov | yes | 3 | 10.91s | ||
| devskim | yes | 2 | 1.17s | ||
| ✅ REPOSITORY | dustilock | yes | no | 0.01s | |
| ✅ REPOSITORY | gitleaks | yes | no | 0.27s | |
| ✅ REPOSITORY | git_diff | yes | no | 0.01s | |
| ✅ REPOSITORY | grype | yes | no | 11.14s | |
| kics | yes | 31 | 1.97s | ||
| ✅ REPOSITORY | secretlint | yes | no | 0.67s | |
| ✅ REPOSITORY | syft | yes | no | 1.05s | |
| trivy | yes | 1 | 5.85s | ||
| ✅ REPOSITORY | trivy-sbom | yes | no | 0.07s | |
| ✅ REPOSITORY | trufflehog | yes | no | 2.94s | |
| ✅ YAML | prettier | 3 | 1 | 0 | 0.55s |
| ✅ YAML | v8r | 3 | 0 | 3.75s | |
| ✅ YAML | yamllint | 3 | 0 | 0.39s |
See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff
2ceacc8 to
42593c4
Compare
….toml with license and dependency organization and refine CI workflow by removing unused validation step
42593c4 to
4df9be0
Compare
…e Ruff configuration to ignore line length violations in comments and string literals
…hance server module documentation, and streamline CLI implementation by removing unnecessary imports
…o enhance code quality checks
… management, update .pylintrc with additional disable rules and settings, enhance pyrightconfig.json and clean up server.py and cli.py by removing unnecessary comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 9 out of 13 changed files in this pull request and generated 1 comment.
Files not reviewed (4)
- .flake8: Language not supported
- .pylintrc: Language not supported
- Dockerfile: Language not supported
- pyrightconfig.json: Language not supported
Comments suppressed due to low confidence (1)
src/browser_use_mcp_server/init.py:8
- The static version 'version = "0.0.0"' may cause confusion when using dynamic versioning. Consider removing it or adding a comment to clarify that the version is dynamically replaced during build.
__version__ = "0.0.0"
…ain function, removing redundant imports, and improving code clarity
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
…ironment variables; remove version declaration from __init__.py
|
🎉 This PR is included in version 1.0.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This pull request includes updates to the GitHub Actions workflow for publishing a Python package and modifications to the
pyproject.tomlfile to integrate dynamic versioning.Changes to GitHub Actions workflow:
.github/workflows/python-publish.yml: Updatedfetch-depthto0in the checkout step to fetch all history. Simplified the build process by combining the build steps and renaming artifact upload step. [1] [2].github/workflows/python-publish.yml: Added a blank line for better readability in thepypi-publishjob.Changes to
pyproject.toml:pyproject.toml: Addeduv-dynamic-versioningto the build requirements and set the project version to be dynamically generated.pyproject.toml: Configureduv-dynamic-versioningto use Git for version control with PEP 440 style and enabled automatic version bumping.Description
To avoid manual labor an commits during releasing, uv dynamic versioning is introduced.
Fixes #35
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
N/A, Action runs after merge
Checklist: