Skip to content

Clean up local launch wording#158

Merged
michiosw merged 1 commit into
mainfrom
feat/eng-329-launch-readiness
May 18, 2026
Merged

Clean up local launch wording#158
michiosw merged 1 commit into
mainfrom
feat/eng-329-launch-readiness

Conversation

@hasandemirkiran
Copy link
Copy Markdown
Contributor

Summary

  • explain the user-facing change
  • link the issue or context if relevant

Verification

  • go test ./...
  • go test -race ./...
  • go vet ./...
  • buf generate if protobuf or generated code changed

Release notes

  • conventional commit title matches semver intent

Copy link
Copy Markdown
Contributor Author

hasandemirkiran commented May 18, 2026

@hasandemirkiran hasandemirkiran changed the base branch from feat/eng-355-command-drawer-overflow to graphite-base/158 May 18, 2026 19:43
@hasandemirkiran hasandemirkiran requested a review from michiosw May 18, 2026 19:43
@hasandemirkiran hasandemirkiran marked this pull request as ready for review May 18, 2026 19:43
@chatgpt-codex-connector
Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@greptile-apps
Copy link
Copy Markdown

greptile-apps Bot commented May 18, 2026

Greptile Summary

This PR removes the local Guard approval state from user-facing wording and dashboard views. It changes:

  • Local launch and Guard docs describe allow/deny decisions only.
  • Former deterministic ask outcomes now become deny outcomes.
  • SQLite summaries fold legacy ask rows into critical deny-style counts.
  • The dashboard removes ask tabs, labels, counts, and visual styling.
  • Generated dashboard assets are updated for the new wording.

Confidence Score: 4/5

This looks safe to merge.

  • No blocking issues found in the changed code.

Reviews (3): Last reviewed commit: "Remove ask from local guard decisions" | Re-trigger Greptile

Comment thread internal/run/local.go
Comment thread internal/guard/cli/cli.go
Comment thread README.md
Comment thread README.md
Comment thread docs/guard.md
Comment thread internal/guard/cli/cli.go
Comment thread internal/run/local.go
@hasandemirkiran hasandemirkiran force-pushed the feat/eng-329-launch-readiness branch from d563f37 to 687ae44 Compare May 18, 2026 19:46
@graphite-app graphite-app Bot changed the base branch from graphite-base/158 to main May 18, 2026 19:47
@hasandemirkiran hasandemirkiran force-pushed the feat/eng-329-launch-readiness branch 3 times, most recently from 1e63eb3 to 350ec04 Compare May 18, 2026 20:19
Copy link
Copy Markdown
Contributor Author

@greptileai

@hasandemirkiran hasandemirkiran force-pushed the feat/eng-329-launch-readiness branch from 350ec04 to 129ee68 Compare May 18, 2026 20:27
Copy link
Copy Markdown
Contributor Author

@greptileai

Copy link
Copy Markdown
Contributor

michiosw commented May 18, 2026

Merge activity

  • May 18, 8:41 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • May 18, 8:41 PM UTC: @michiosw merged this pull request with Graphite.

@michiosw michiosw merged commit 032e13a into main May 18, 2026
5 checks passed
@michiosw michiosw deleted the feat/eng-329-launch-readiness branch May 18, 2026 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants