👻 make release workflow callable#533
Merged
pranavgaikwad merged 4 commits intokonveyor:mainfrom Jan 7, 2025
Merged
Conversation
Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
f72bb7e to
9452d87
Compare
Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
Contributor
Author
|
This will help address issues like konveyor/editor-extensions#156. |
djzager
reviewed
Jan 6, 2025
Member
djzager
left a comment
There was a problem hiding this comment.
Just one comment. Otherwise it lgtm.
djzager
approved these changes
Jan 6, 2025
Contributor
Author
|
Discussed this offline with @djzager...we need to update this PR to include the bundle for all platforms. going to move this to draft until I add that piece here |
Member
|
Any way to make this an action instead of a reusable workflow? That way it can integrated better into other PR workflows as a simple step instead of chained runs? @djzager -- Do you see any advantages for doing it that way over the reusable workflows? Edit: Now I see the matrix of all the platforms -- yeah not sure that is doable as an action. Oh well. |
e1d03d9 to
88d311b
Compare
Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
c84f061 to
958aa5d
Compare
Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
shawn-hurley
approved these changes
Jan 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #520
Here is an example of a calling workflow that can use this workflow. It runs this workflow to build Kai binaries for all platforms and does its own things on the same platforms: