Skip to content

👻 make release workflow callable#533

Merged
pranavgaikwad merged 4 commits intokonveyor:mainfrom
pranavgaikwad:main
Jan 7, 2025
Merged

👻 make release workflow callable#533
pranavgaikwad merged 4 commits intokonveyor:mainfrom
pranavgaikwad:main

Conversation

@pranavgaikwad
Copy link
Copy Markdown
Contributor

@pranavgaikwad pranavgaikwad commented Jan 2, 2025

Fixes #520

Here is an example of a calling workflow that can use this workflow. It runs this workflow to build Kai binaries for all platforms and does its own things on the same platforms:

name: test

on:
  workflow_dispatch:

jobs:
  kai_build:
    uses: konveyor/kai/.github/workflows/build-and-push-binaries.yml@main

  plugin_build:
    name: plugin build
    needs: kai_build
    strategy:
      matrix:
        runs_on: ${{ fromJson(needs.kai_build.outputs.matrix_info) }}
    runs-on: ${{ matrix.runs_on.os }}
    steps:
      - name: Download kai binaries
        uses: actions/download-artifact@v3
        with:
          name: kai-rpc-server.${{ env.OS }}-${{ env.OS_ARCH }}.zip
          path: kai-rpc-server.${{ env.OS }}-${{ env.OS_ARCH }}.zip
      - name: Build and package the IDE plugin
        run: | 
          # do whatever you need to do to build your own thing

Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
@pranavgaikwad pranavgaikwad force-pushed the main branch 19 times, most recently from f72bb7e to 9452d87 Compare January 3, 2025 17:01
@pranavgaikwad pranavgaikwad marked this pull request as ready for review January 3, 2025 17:02
Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
@pranavgaikwad
Copy link
Copy Markdown
Contributor Author

This will help address issues like konveyor/editor-extensions#156.

Copy link
Copy Markdown
Member

@djzager djzager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment. Otherwise it lgtm.

Comment thread .github/workflows/build-and-push-binaries.yml
@pranavgaikwad
Copy link
Copy Markdown
Contributor Author

Discussed this offline with @djzager...we need to update this PR to include the bundle for all platforms. going to move this to draft until I add that piece here

@pranavgaikwad pranavgaikwad marked this pull request as draft January 6, 2025 18:18
@sjd78
Copy link
Copy Markdown
Member

sjd78 commented Jan 6, 2025

Any way to make this an action instead of a reusable workflow? That way it can integrated better into other PR workflows as a simple step instead of chained runs?

@djzager -- Do you see any advantages for doing it that way over the reusable workflows?

Edit: Now I see the matrix of all the platforms -- yeah not sure that is doable as an action. Oh well.

@pranavgaikwad pranavgaikwad force-pushed the main branch 6 times, most recently from e1d03d9 to 88d311b Compare January 6, 2025 20:24
Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
@pranavgaikwad pranavgaikwad force-pushed the main branch 5 times, most recently from c84f061 to 958aa5d Compare January 7, 2025 13:22
@dymurray dymurray added this to the v0.0.5 milestone Jan 7, 2025
Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
@pranavgaikwad pranavgaikwad marked this pull request as ready for review January 7, 2025 16:13
@pranavgaikwad pranavgaikwad requested a review from djzager January 7, 2025 16:19
Copy link
Copy Markdown
Member

@djzager djzager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pranavgaikwad pranavgaikwad merged commit 25a084e into konveyor:main Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFE] Make GitHub actions use make instead of raw commands for e2e tests

5 participants