🐛 Fixes #472 Remove stateless kai resources when set to false

[jmontleon]

Summary by CodeRabbit

• Bug Fixes

  • Ensured config always includes a proper models mapping and added a terminating newline to avoid parsing issues.

• Refactor

  • Simplified deployment logic to use centralized state flags, reducing nested conditions and improving reliability of component provisioning.

• Chores

  • Rendered database-related environment settings only when the corresponding service is enabled to prevent unnecessary configuration exposure.

[coderabbitai]

📝 Walkthrough

Walkthrough

Centralizes deployment state in Ansible tasks, converting nested conditionals to state-driven tasks for KAI DB, LLM Proxy, and Solution Server; ensures kai-api deployment only sets KAI_DB_DSN when the solution server is enabled; fixes llm-proxy ConfigMap YAML by providing models: [] in the else-branch and adds a trailing newline.

Changes

Cohort / File(s)	Summary
LLM Proxy ConfigMap template roles/tackle/templates/kai/llm-proxy-configmap.yaml.j2	Fix else-branch YAML to include models: [] (ensures models key exists) and add a trailing newline at EOF.
Ansible task flow roles/tackle/tasks/kai.yml	Replace nested conditional blocks with centralized state facts (kai_common_state, kai_llm_proxy_state, kai_solution_server_state) and convert DB, LLM Proxy, and Solution Server resources into discrete tasks gated by those state variables.
Kai API deployment template roles/tackle/templates/kai/kai-api-deployment.yaml.j2	Wrap KAI_DB_DSN env var rendering in a Jinja conditional so it is included only when kai_solution_server_enabled is true.

Sequence Diagram(s)

sequenceDiagram
  participant Ansible
  participant StateCalc as "State Calculator"
  participant K8sAPI as "Kubernetes API"
  participant LLMProxy as "LLM Proxy Components"
  participant SolutionAPI as "KAI Solution Server"
  participant DB as "KAI DB"

  rect rgba(200,220,255,0.5)
  Ansible->>StateCalc: Evaluate kai_common_state, kai_llm_proxy_state, kai_solution_server_state
  StateCalc-->>Ansible: States
  end

  rect rgba(200,255,200,0.5)
  Ansible->>K8sAPI: Create/merge KAI DB (if kai_common_state)
  K8sAPI-->>DB: Deploy DB resources
  end

  rect rgba(255,230,200,0.5)
  Ansible->>K8sAPI: Create ConfigMap, Deployment, Service for LLM Proxy (if kai_llm_proxy_state)
  K8sAPI-->>LLMProxy: Provision LLM Proxy resources
  end

  rect rgba(255,200,220,0.5)
  Ansible->>K8sAPI: Deploy KAI Solution Server (if kai_solution_server_state)
  K8sAPI-->>SolutionAPI: Deploy Solution Server (env KAI_DB_DSN only rendered when enabled)
  end

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 I hopped through tasks both near and far,
States aligned like twinkling stars,
Configs tidy, envs now true,
Deployments hum—hooray! anew 🌱

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: fixing an issue where stateless KAI resources are not properly removed when disabled. The changes across multiple files implement state-driven control to ensure resources are cleaned up when set to false.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 2

🤖 Fix all issues with AI agents

In `@roles/tackle/tasks/kai.yml`:
- Around line 83-87: The ConfigMap task "Create LLM Proxy Client Configuration"
currently uses "state: present" with "when: kai_solution_server_enabled | bool"
so it is skipped rather than removed when the server is disabled; change the
task to set state conditionally (e.g. state: present if
kai_solution_server_enabled | bool else absent) or drive state from the
lifecycle variable kai_solution_server_state so the k8s module will create or
delete the template kai/llm-proxy-client-configmap.yaml.j2 appropriately instead
of merely skipping the task.
- Around line 67-71: The ConfigMap task "Create LLM Proxy ConfigMap" currently
uses state: present with a when: kai_llm_proxy_enabled | bool so it is only
skipped when disabled and never removed; change it to always run and set the
state based on kai_llm_proxy_enabled (e.g. state: "{{ 'present' if
kai_llm_proxy_enabled | bool else 'absent' }}") and remove the when clause,
keeping the same template kai/llm-proxy-configmap.yaml.j2 so the ConfigMap is
created when true and deleted when false.

🧹 Nitpick comments (1)

roles/tackle/tasks/kai.yml (1)

73-98: Minor: Inconsistent spacing after state:.

Some lines have double spaces (state: "{{ ... }}"), others have single. Consider normalizing for consistency.

✨ Proposed fix for spacing consistency

 - name: Create LLM Proxy Deployment
   k8s:
-    state:  "{{ kai_llm_proxy_state }}"
+    state: "{{ kai_llm_proxy_state }}"
     template: kai/llm-proxy-deployment.yaml.j2

 - name: Create LLM Proxy Service
   k8s:
-    state:  "{{ kai_llm_proxy_state }}"
+    state: "{{ kai_llm_proxy_state }}"
     template: kai/llm-proxy-service.yaml.j2

(Same for lines 91 and 97)

[fabianvf]

Not sure why the test failed so unhelpfully

[fabianvf]

Minor nit, this template is for the kai-solution-server, so I don't think we need this extra guard

[jmontleon]

When kai-solution-server is false pg_password is undefined causing an undefined variable error if it's not guarded by the conditional.

[mguetta1]

LGTM

[konveyor-ci-bot]

PR cherry-picked to branch release-0.9. Backport PR: #539