fix(docs): destroy examples before fetching new document (#DS-4159) #1020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where live example components were not being properly destroyed when navigating to new pages. The fix ensures that all live examples are cleared before fetching new documents to prevent memory leaks and stale component instances.
- Adds proper cleanup of live examples before fetching new documents
- Ensures component destruction lifecycle is properly handled during navigation
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| apps/docs/src/app/components/live-example/docs-live-example.ts | Adds clearLiveExamples() call before getDocument() to ensure cleanup |
| apps/docs/src/app/components/example-viewer/example-viewer.ts | Adds clearLiveExamples() call before fetchDocument() to ensure cleanup |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Visit the preview URL for this PR (updated for commit 9200e0f): https://koobiq-next--prs-1020-x191r8l9.web.app (expires Wed, 17 Sep 2025 10:32:41 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c |
NikGurev
approved these changes
Sep 14, 2025
lskramarov
approved these changes
Sep 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
при переходе на новую страницу не происходит "destroy" компонента-примера