-
Notifications
You must be signed in to change notification settings - Fork 3
feat(inline-edit): aligned focus order (#DS-4210) #1052
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1cd739e to
040e116
Compare
|
Visit the preview URL for this PR (updated for commit ca0d162): https://koobiq-next--prs-1052-2zmlglxv.web.app (expires Wed, 22 Oct 2025 09:36:11 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c |
lskramarov
approved these changes
Oct 16, 2025
artembelik
approved these changes
Oct 16, 2025
Contributor
rmnturov
approved these changes
Oct 17, 2025
Contributor
Author
|
@rmnturov убрал пример с тегами, заменил на бейджи |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Redesigned the focus logic, following the UX principle: 'content first, everything else after.'
Initially wanted to implement it using
CdkFocusTrapand focus delegation, but realized that this approach works differently across browsers.In the end, implemented it natively by adding an overlay that renders the focus border.
This way, the focus order became correct:
Press for description in ru-RU
Переделал логику фокусировки, следуя UX-правилу: "сначала контент, потом все остальное".
Сначала хотел реализовать с помощью
CdkFocusTrapи прокидыванием фокуса, но понял, что такой подход в браузерах работает по-разному.По итогу, реализовал нативно, добавив оверлей, который отрисовывает рамку фокуса.
Таким образом, порядок фокусировки стал верный: