fix(file-upload): set focus after delete properly (#DS-4090) #1058
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 06575bd): https://koobiq-next--prs-1058-isjsu1nk.web.app (expires Mon, 27 Oct 2025 14:01:00 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c |
artembelik
reviewed
Oct 16, 2025
artembelik
approved these changes
Oct 16, 2025
Contributor
|
При удалении мышкой рамка фокуса не нужна |
Contributor
Author
|
@rmnturov поправил рамку фокуса |
rmnturov
approved these changes
Oct 17, 2025
lskramarov
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ListSelectioncomponent controls the selection of the active element when deleting from within, I created a wrapper around this behavior.Press for description in ru-RU
Добавил фокус на лейбл, когда список файлов становится пустым.
Разобрался с установкой фокуса активного элемента. Так как компонент
ListSelectionконтролирует выбор активного элемента при удалении изнутри, то сделал обертку вокруг этого поведения.Добавил тесты