-
Notifications
You must be signed in to change notification settings - Fork 3
feat(tags): added SPACE key support for selection (#DS-4265) #1065
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8034fc0 to
98f9d99
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds keyboard accessibility support for tag selection using the SPACE key. When a tag has focus, pressing SPACE will now toggle its selection state, providing an alternative to clicking or using ENTER/F2.
Key changes:
- Added SPACE key handler to toggle tag selection in the tag component
- Updated documentation across all tag-related components (tag, tag-list, tag-input, tag-autocomplete) in both English and Russian
- Added comprehensive test coverage for SPACE key functionality
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/components/tags/tag.component.ts | Added SPACE key import and handlers for selection toggling and event propagation prevention |
| packages/components/tags/tag.component.spec.ts | Added tests for SPACE key selection behavior and event emission; improved test description clarity |
| packages/components/tags/tag-list.component.spec.ts | Added tests for SPACE key in multiple selection mode; updated test data structure from string values to objects |
| packages/components/tags/tag.ru.md | Documented SPACE key selection in Russian |
| packages/components/tags/tag.en.md | Documented SPACE key selection in English |
| packages/components/tags/tag-list.ru.md | Documented SPACE key selection in Russian for tag lists |
| packages/components/tags/tag-list.en.md | Documented SPACE key selection in English for tag lists |
| packages/components/tags/tag-input.ru.md | Documented SPACE key selection in Russian for tag inputs |
| packages/components/tags/tag-input.en.md | Documented SPACE key selection in English for tag inputs |
| packages/components/tags/tag-autocomplete.ru.md | Documented SPACE key selection in Russian for tag autocomplete |
| packages/components/tags/tag-autocomplete.en.md | Documented SPACE key selection in English for tag autocomplete |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Visit the preview URL for this PR (updated for commit 98f9d99): https://koobiq-next--prs-1065-4kiqu02d.web.app (expires Sun, 26 Oct 2025 09:43:28 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c |
|
можно доработать отдельно, средний приоритет. |
|
базово я глянул. круто работает |
DS-4299 |
No description provided.