Skip to content

Conversation

@artembelik
Copy link
Contributor

No description provided.

@artembelik artembelik self-assigned this Oct 21, 2025
@artembelik artembelik requested review from Copilot and removed request for Copilot October 21, 2025 09:35
@artembelik artembelik requested a review from NikGurev as a code owner October 21, 2025 09:35
Copilot AI review requested due to automatic review settings October 21, 2025 09:37
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds keyboard accessibility support for tag selection using the SPACE key. When a tag has focus, pressing SPACE will now toggle its selection state, providing an alternative to clicking or using ENTER/F2.

Key changes:

  • Added SPACE key handler to toggle tag selection in the tag component
  • Updated documentation across all tag-related components (tag, tag-list, tag-input, tag-autocomplete) in both English and Russian
  • Added comprehensive test coverage for SPACE key functionality

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/components/tags/tag.component.ts Added SPACE key import and handlers for selection toggling and event propagation prevention
packages/components/tags/tag.component.spec.ts Added tests for SPACE key selection behavior and event emission; improved test description clarity
packages/components/tags/tag-list.component.spec.ts Added tests for SPACE key in multiple selection mode; updated test data structure from string values to objects
packages/components/tags/tag.ru.md Documented SPACE key selection in Russian
packages/components/tags/tag.en.md Documented SPACE key selection in English
packages/components/tags/tag-list.ru.md Documented SPACE key selection in Russian for tag lists
packages/components/tags/tag-list.en.md Documented SPACE key selection in English for tag lists
packages/components/tags/tag-input.ru.md Documented SPACE key selection in Russian for tag inputs
packages/components/tags/tag-input.en.md Documented SPACE key selection in English for tag inputs
packages/components/tags/tag-autocomplete.ru.md Documented SPACE key selection in Russian for tag autocomplete
packages/components/tags/tag-autocomplete.en.md Documented SPACE key selection in English for tag autocomplete

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions
Copy link

github-actions bot commented Oct 21, 2025

Visit the preview URL for this PR (updated for commit 98f9d99):

https://koobiq-next--prs-1065-4kiqu02d.web.app

(expires Sun, 26 Oct 2025 09:43:28 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c

@rmnturov
Copy link
Contributor

можно доработать отдельно, средний приоритет.
а можно делать так, чтобы при нажатии пробела появлялась рамка фокуса? было же управление с клавы. кейс: отметил несколько с помощью ctrl+click. затем нажал пробел, последний выбранный отжался. вот на нем и появится рамка фокуса

@rmnturov
Copy link
Contributor

rmnturov commented Oct 21, 2025

базово я глянул. круто работает

@artembelik artembelik requested a review from lskramarov October 22, 2025 08:31
@artembelik
Copy link
Contributor Author

можно доработать отдельно, средний приоритет.

DS-4299

@artembelik artembelik merged commit b19df88 into main Oct 22, 2025
4 checks passed
@artembelik artembelik deleted the feat/DS-4265 branch October 22, 2025 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants