-
Notifications
You must be signed in to change notification settings - Fork 3
feat(tags): apply KbqFieldSizingContent directive to KbqTagInput (#DS-4204) #1066
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds the KbqFieldSizingContent directive to KbqTagInput to enable automatic input width sizing based on content. The change replaces the previous manual width calculation logic with the standard directive, improving maintainability and consistency across form inputs.
Key changes:
- Applied
KbqFieldSizingContentdirective toKbqTagInputviahostDirectives - Removed manual width calculation logic (
updateInputWidth,oneSymbolWidth,setDefaultInputWidth) - Updated styles to use standard input reset mixin and CSS variables
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/public_api_guard/components/tags.api.md | Updated public API to reflect KbqFieldSizingContent directive addition and deprecated methods |
| packages/docs-examples/components/tag/tag-input-draggable/tag-input-draggable-example.ts | Added KbqInputModule import and legacy validation provider for example compatibility |
| packages/docs-examples/components/tag/tag-autocomplete-option-operations/tag-autocomplete-option-operations-example.ts | Added KbqInputModule import, kbqInput directive, and legacy validation provider |
| packages/components/tags/tag-list.scss | Refactored styles to use input reset mixin and CSS variables for consistent sizing |
| packages/components/tags/tag-input.ts | Removed manual width calculation logic, added KbqFieldSizingContent host directive, deprecated unused methods |
| packages/components/core/form-field/field-sizing-content.ts | Fixed placeholder truncation in Safari/Firefox by adding space to placeholder text |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Visit the preview URL for this PR (updated for commit 7df6b63): https://koobiq-next--prs-1066-962er8gn.web.app (expires Mon, 10 Nov 2025 11:21:38 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c |
394e9c3 to
7df6b63
Compare
поправил |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

No description provided.