Skip to content

Conversation

@artembelik
Copy link
Contributor

@artembelik artembelik commented Oct 21, 2025

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds the KbqFieldSizingContent directive to KbqTagInput to enable automatic input width sizing based on content. The change replaces the previous manual width calculation logic with the standard directive, improving maintainability and consistency across form inputs.

Key changes:

  • Applied KbqFieldSizingContent directive to KbqTagInput via hostDirectives
  • Removed manual width calculation logic (updateInputWidth, oneSymbolWidth, setDefaultInputWidth)
  • Updated styles to use standard input reset mixin and CSS variables

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tools/public_api_guard/components/tags.api.md Updated public API to reflect KbqFieldSizingContent directive addition and deprecated methods
packages/docs-examples/components/tag/tag-input-draggable/tag-input-draggable-example.ts Added KbqInputModule import and legacy validation provider for example compatibility
packages/docs-examples/components/tag/tag-autocomplete-option-operations/tag-autocomplete-option-operations-example.ts Added KbqInputModule import, kbqInput directive, and legacy validation provider
packages/components/tags/tag-list.scss Refactored styles to use input reset mixin and CSS variables for consistent sizing
packages/components/tags/tag-input.ts Removed manual width calculation logic, added KbqFieldSizingContent host directive, deprecated unused methods
packages/components/core/form-field/field-sizing-content.ts Fixed placeholder truncation in Safari/Firefox by adding space to placeholder text

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions
Copy link

github-actions bot commented Oct 21, 2025

Visit the preview URL for this PR (updated for commit 7df6b63):

https://koobiq-next--prs-1066-962er8gn.web.app

(expires Mon, 10 Nov 2025 11:21:38 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c

@artembelik artembelik marked this pull request as draft October 22, 2025 09:42
@rmnturov
Copy link
Contributor

Артем, инпутом должно быть все, что правее тегов в строке. Неприятный эффект сейчас, тыкаешь в пустое место, как обычно ожидаешь, что фокус в инпут встанет, а не получается такого, так ширина инпута равна плейхолдеру
изображение

При переносе плейсхолдера на новую строку инпутом будет вся новая строка без тегов

@artembelik artembelik marked this pull request as ready for review November 5, 2025 11:29
@artembelik
Copy link
Contributor Author

инпутом должно быть все, что правее тегов в строке

поправил

@artembelik artembelik requested a review from Copilot November 5, 2025 11:30
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@lskramarov lskramarov merged commit a0412f8 into main Nov 7, 2025
10 checks passed
@lskramarov lskramarov deleted the feat/DS-4204 branch November 7, 2025 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants