Skip to content

Conversation

@artembelik
Copy link
Contributor

No description provided.

@artembelik artembelik requested a review from rmnturov October 30, 2025 15:03
@artembelik artembelik self-assigned this Oct 30, 2025
Copilot AI review requested due to automatic review settings October 30, 2025 15:03
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the tag component's drag-and-drop focus management by removing automatic focus restoration logic and delegating focus control to example implementations. The key changes simplify the internal drag data structure and improve consistency across documentation examples.

  • Removed automatic focus restoration in tag-list after drag operations
  • Simplified KbqDragData type by removing focus-related properties
  • Updated all documentation examples to explicitly handle focus after tag removal and drag operations
  • Renamed remove methods to removed across examples for better semantic clarity

Reviewed Changes

Copilot reviewed 23 out of 23 changed files in this pull request and generated 1 comment.

File Description
tools/public_api_guard/components/tags.api.md Removed FocusOrigin import and focus-related properties from KbqDragData type
packages/components/tags/tag.component.ts Removed focusOrigin tracking, debounceTime import, and simplified drag data initialization
packages/components/tags/tag-list.component.ts Removed automatic focus restoration logic from dropped event handler
packages/docs-examples/components/tag/*/* Added explicit focus management in examples and renamed remove to removed for event handlers

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

github-actions bot commented Oct 30, 2025

Visit the preview URL for this PR (updated for commit c257bd1):

https://koobiq-next--prs-1084-nafv2wn4.web.app

(expires Wed, 05 Nov 2025 14:11:34 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c

@artembelik artembelik merged commit 7ebc0b9 into main Nov 1, 2025
4 checks passed
@artembelik artembelik deleted the fix/DS-4271 branch November 1, 2025 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants