-
Notifications
You must be signed in to change notification settings - Fork 3
fix(tags): focus behavior on remove and drop (#DS-4271) #1084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the tag component's drag-and-drop focus management by removing automatic focus restoration logic and delegating focus control to example implementations. The key changes simplify the internal drag data structure and improve consistency across documentation examples.
- Removed automatic focus restoration in tag-list after drag operations
- Simplified
KbqDragDatatype by removing focus-related properties - Updated all documentation examples to explicitly handle focus after tag removal and drag operations
- Renamed
removemethods toremovedacross examples for better semantic clarity
Reviewed Changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tools/public_api_guard/components/tags.api.md | Removed FocusOrigin import and focus-related properties from KbqDragData type |
| packages/components/tags/tag.component.ts | Removed focusOrigin tracking, debounceTime import, and simplified drag data initialization |
| packages/components/tags/tag-list.component.ts | Removed automatic focus restoration logic from dropped event handler |
| packages/docs-examples/components/tag/*/* | Added explicit focus management in examples and renamed remove to removed for event handlers |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/docs-examples/components/tag/tag-list-draggable/tag-list-draggable-example.ts
Show resolved
Hide resolved
|
Visit the preview URL for this PR (updated for commit c257bd1): https://koobiq-next--prs-1084-nafv2wn4.web.app (expires Wed, 05 Nov 2025 14:11:34 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c |
No description provided.