fix(toggle): layout based on label presence (#DS-4293) #1087
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the toggle component's CSS to use the :has() pseudo-class for conditional styling based on label content presence, improving specificity and maintainability. It also standardizes token naming conventions.
- Replaced adjacent sibling selector with
:has()pseudo-class to check for non-empty labels - Wrapped margin rules for
.leftand.rightclasses within label presence checks - Updated token name from
toggle-font-big-label-line-heighttotypography-text-big-line-heightfor consistency - Removed redundant
.kbq-hintmargin rule for big toggle variant
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Visit the preview URL for this PR (updated for commit 803c01b): https://koobiq-next--prs-1087-q5zj4983.web.app (expires Wed, 05 Nov 2025 13:34:01 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c |
rmnturov
approved these changes
Nov 1, 2025
NikGurev
approved these changes
Nov 1, 2025
lskramarov
approved these changes
Nov 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.