-
Notifications
You must be signed in to change notification settings - Fork 3
style: enabled no-console eslint rule (#DS-2920) #1104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements ESLint enforcement for console statement usage across the codebase. The main goal is to establish a consistent policy for console usage by enabling the no-console rule as a warning, with appropriate exemptions for specific contexts.
- Added
'no-console': 1to base JavaScript/TypeScript rules to warn on console usage - Removed debug console.log statements from test files
- Added eslint-disable comments for legitimate console.warn/error usage in production code
- Created exemptions for tools, schematics, CLI, examples, and dev packages where console usage is acceptable
Reviewed Changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| .eslintrc.js | Added base no-console rule and exemptions for tools, schematics, CLI, dev, and examples directories |
| packages/components/tree-select/tree-select.component.spec.ts | Removed debug console.log statement |
| packages/components/toast/toast.spec.ts | Replaced console.log with empty function in test timer |
| packages/components/select/select.component.ts | Added eslint-disable comment for legitimate console.warn |
| packages/components/select/select.component.spec.ts | Removed debug console.log statement |
| packages/components/modal/modal.service.ts | Added eslint-disable comment for legitimate console.warn |
| packages/components/modal/modal.karma-spec.ts | Replaced console.log with empty function in test callback |
| packages/components/filter-bar/filter-bar.karma-spec.ts | Removed debug console.log statements |
| packages/components/file-upload/file-drop.ts | Added eslint-disable comment for legitimate console.warn |
| packages/components/core/pop-up/pop-up-trigger.ts | Added eslint-disable comment for legitimate console.warn |
| packages/components/core/common-behaviors/tabindex.ts | Added eslint-disable comment for deprecation console.warn |
| packages/components/core/common-behaviors/error-state.ts | Added eslint-disable comment for deprecation console.warn |
| packages/components/core/common-behaviors/disabled.ts | Added eslint-disable comment for deprecation console.warn |
| packages/components/core/common-behaviors/common-module.ts | Added eslint-disable comment for legitimate console.warn |
| packages/components/core/common-behaviors/color.ts | Added eslint-disable comment for deprecation console.warn |
| packages/components/code-block/code-block-highlight.ts | Added eslint-disable comments for legitimate console.warn/error usage |
| packages/components/app-switcher/app-switcher.spec.ts | Removed debug console.log statements and added eslint-disable for unused test variables |
| apps/docs/scripts/build-tokens.js | Added file-level eslint-disable for console usage in build script |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Visit the preview URL for this PR (updated for commit 5b122fc): https://koobiq-next--prs-1104-mjsgw6o2.web.app (expires Wed, 12 Nov 2025 12:55:55 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c |
33b34b2 to
8c269f4
Compare
No description provided.