-
Notifications
You must be signed in to change notification settings - Fork 3
chore: updated dev ssr application based on official docs #1105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the SSR (Server-Side Rendering) configuration for the Angular development application by extracting shared configuration into separate files and updating the bootstrap code. The main goal is to improve code organization by centralizing application configuration.
- Extracted shared Angular providers into
config.tsandconfig.server.tsfiles - Refactored
main.tsandmain.server.tsto use the new configuration files - Added README documentation for the SSR development application
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
packages/components-dev/ssr/server.ts |
Minor formatting improvement to inline comment |
packages/components-dev/ssr/main.ts |
Refactored to import and use shared config instead of inline providers |
packages/components-dev/ssr/main.server.ts |
Refactored to import server config; however, introduces incorrect API usage with BootstrapContext |
packages/components-dev/ssr/config.ts |
New file containing shared application configuration for client and server |
packages/components-dev/ssr/config.server.ts |
New file merging base config with server-specific providers; missing event replay configuration |
packages/components-dev/ssr/README.md |
New documentation file with setup and development instructions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
Visit the preview URL for this PR (updated for commit f69a3a2): https://koobiq-next--prs-1105-8lxaggnh.web.app (expires Wed, 12 Nov 2025 12:25:10 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c |
No description provided.