Skip to content

Conversation

@artembelik
Copy link
Contributor

@artembelik artembelik commented Nov 11, 2025

  • клавиатурный фокус при выделении пробелом
  • отключение выделения по умолчанию для single тегов

@artembelik artembelik self-assigned this Nov 11, 2025
Copilot AI review requested due to automatic review settings November 11, 2025 11:20
@artembelik artembelik added the bug Something isn't working label Nov 11, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the focus handling when the SPACE key is pressed on tags by ensuring the tag receives keyboard focus with the correct focus origin.

  • Added a new KbqTagFocusEvent type that extends KbqTagEvent with a FocusOrigin property
  • Modified the SPACE keydown handler to explicitly set keyboard focus using FocusMonitor.focusVia()
  • Updated the tag list's focus listener to propagate the focus origin to the FocusKeyManager

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
tools/public_api_guard/components/tags.api.md Updated public API surface to reflect type changes for tag focus events
packages/components/tags/tag.component.ts Added KbqTagFocusEvent type, updated SPACE keydown to call focusVia(), and modified focus event emission to include origin
packages/components/tags/tag-list.component.ts Updated imports and modified listenToTagsFocus() to extract and set focus origin on the key manager
packages/components/tags/tag.component.spec.ts Added test case to verify that pressing SPACE focuses the tag

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

github-actions bot commented Nov 11, 2025

Visit the preview URL for this PR (updated for commit 6a56c32):

https://koobiq-next--prs-1112-zi85c7oh.web.app

(expires Tue, 18 Nov 2025 10:09:15 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c

@lskramarov lskramarov requested a review from rmnturov November 11, 2025 14:34
@artembelik
Copy link
Contributor Author

artembelik commented Nov 12, 2025

обсудить:

  1. shift+tab не работает
  2. как попасть (focus) в тег-лист в тег-инпуте без использования мыши?
  3. нужно ли давать возможность выбирать (selected) тег без тег-листа?

upd.

  1. необходима доработка (DS-4367)
  2. необходима доработка (DS-4367)
  3. нет, поправлю в этом пре

@artembelik
Copy link
Contributor Author

artembelik commented Nov 12, 2025

разобраться с багом при клике на тег, он сперва выделяется, затем сбрасывает выделение

@NikGurev
Copy link
Contributor

разобраться с багом при клике на тег, он сперва выделяется, затем сбрасывает выделение

у меня не воспроизводится

@NikGurev
Copy link
Contributor

как попасть (focus) в тег-лист в тег-инпуте без использования мыши?

тег-лист должен фокусироваться в тег инпуте? Сейчас фокусирует

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@artembelik artembelik changed the title fix(tags): focus on SPACE keydown (#DS-4299) fix(tags): focus on SPACE keydown, default selection for single tag (#DS-4299) Nov 13, 2025
@artembelik artembelik merged commit 00121d6 into main Nov 15, 2025
14 checks passed
@artembelik artembelik deleted the fix/DS-4299 branch November 15, 2025 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants