-
Notifications
You must be signed in to change notification settings - Fork 3
fix(tags): focus on SPACE keydown, default selection for single tag (#DS-4299) #1112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes the focus handling when the SPACE key is pressed on tags by ensuring the tag receives keyboard focus with the correct focus origin.
- Added a new
KbqTagFocusEventtype that extendsKbqTagEventwith aFocusOriginproperty - Modified the SPACE keydown handler to explicitly set keyboard focus using
FocusMonitor.focusVia() - Updated the tag list's focus listener to propagate the focus origin to the
FocusKeyManager
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tools/public_api_guard/components/tags.api.md | Updated public API surface to reflect type changes for tag focus events |
| packages/components/tags/tag.component.ts | Added KbqTagFocusEvent type, updated SPACE keydown to call focusVia(), and modified focus event emission to include origin |
| packages/components/tags/tag-list.component.ts | Updated imports and modified listenToTagsFocus() to extract and set focus origin on the key manager |
| packages/components/tags/tag.component.spec.ts | Added test case to verify that pressing SPACE focuses the tag |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Visit the preview URL for this PR (updated for commit 6a56c32): https://koobiq-next--prs-1112-zi85c7oh.web.app (expires Tue, 18 Nov 2025 10:09:15 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c |
|
обсудить:
upd.
|
|
разобраться с багом при клике на тег, он сперва выделяется, затем сбрасывает выделение |
у меня не воспроизводится |
тег-лист должен фокусироваться в тег инпуте? Сейчас фокусирует |
1833f94 to
6a56c32
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Uh oh!
There was an error while loading. Please reload this page.