Skip to content

Conversation

@artembelik
Copy link
Contributor

No description provided.

@artembelik artembelik self-assigned this Nov 14, 2025
@artembelik
Copy link
Contributor Author

#1115

@github-actions
Copy link

github-actions bot commented Nov 14, 2025

Visit the preview URL for this PR (updated for commit 99a441f):

https://koobiq-next--prs-1121-big64vi3.web.app

(expires Mon, 24 Nov 2025 10:22:13 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c

@artembelik artembelik mentioned this pull request Nov 17, 2025
@artembelik artembelik force-pushed the feat/DS-3683 branch 2 times, most recently from 45fad76 to cf249e4 Compare November 18, 2025 14:38
@artembelik artembelik requested a review from NikGurev November 19, 2025 10:32
@artembelik artembelik marked this pull request as ready for review November 19, 2025 10:32
Copilot AI review requested due to automatic review settings November 19, 2025 10:32
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the documentation application to Server-Side Rendering (SSR) using Angular's built-in SSR capabilities with Express.js. The migration modernizes the build infrastructure and improves initial page load performance and SEO.

  • Introduces SSR with Angular Universal using the new @angular-devkit/build-angular:application builder
  • Adds Express server configuration with CommonEngine for server-side rendering
  • Updates Firebase hosting configuration to support SSR output structure with browser/server folders

Reviewed Changes

Copilot reviewed 13 out of 14 changed files in this pull request and generated 12 comments.

Show a summary per file
File Description
angular.json Migrated from browser builder to application builder with SSR and prerendering support; reorganized schematics configuration to project root
firebase.json Updated public paths to browser subdirectory and changed rewrite destination to index.csr.html for SSR compatibility
package.json, yarn.lock Pinned @types/express to specific version 4.17.21 instead of range ^4
apps/docs/tsconfig.json Removed redundant compiler options and added path mapping for docs-examples package
apps/docs/tsconfig.app.json Added Node types, server entry files, and updated docs-examples path mapping
apps/docs/src/server.ts New Express server implementation with CommonEngine for SSR rendering
apps/docs/src/main.server.ts New server-side bootstrap entry point
apps/docs/src/config.server.ts Server configuration with Window API mocks for SSR compatibility
apps/docs/src/config.ts Extracted shared application configuration with HttpClient fetch support
apps/docs/src/main.ts Simplified client bootstrap to use extracted configuration
apps/docs/src/app/components/anchors/anchors.component.ts Added SSR compatibility checks for DOM APIs and return type annotations
apps/docs/README.md Completely rewritten with clearer development setup instructions
packages/docs-examples/ng-package.json Changed build output from node_modules to dist directory

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@NikGurev
Copy link
Contributor

Кликал по страницам, такое вылезло

ERROR TypeError: this.window.addEventListener is not a function
    at _autocompleteDisabled (/Users/nguryev/Dev/work-opensource/angular-components/packages/components/autocomplete/autocomplete-trigger.directive.ts:224:54)

@artembelik
Copy link
Contributor Author

Кликал по страницам, такое вылезло

#1129

@artembelik artembelik merged commit 4d18a40 into main Nov 19, 2025
14 checks passed
@artembelik artembelik deleted the feat/DS-3683 branch November 19, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants