-
Notifications
You must be signed in to change notification settings - Fork 3
chore(ag-grid): bump @koobiq/ag-grid-angular-theme to 34 version, updated examples (#DS-3957) #1135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…updated examples (#DS-3957)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR upgrades the AG Grid dependencies from version 30 to version 34, updating both the core grid libraries and the Koobiq theme package. The changes include necessary code migrations to adapt to AG Grid v34's new modular architecture and updated selection API.
Key Changes:
- Upgraded
@koobiq/ag-grid-angular-themefrom ^30.2.0 to ^34.0.0 - Upgraded
ag-grid-angularfrom ^30.2.1 to ^34.3.1 andag-grid-communityfrom ^30.2.1 to ^34.3.1 - Migrated row selection from deprecated string-based API to new
RowSelectionOptionsobject pattern - Added explicit module registration using
ModuleRegistry.registerModules([AllCommunityModule]) - Removed manual checkbox column definitions in favor of auto-generated selection columns
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| yarn.lock | Updated dependency resolution for AG Grid packages to v34, including new peer dependencies and checksums |
| package.json | Updated AG Grid dependencies to v34 versions in root package.json |
| apps/docs/src/assets/stackblitz/package.json | Updated AG Grid dependencies for StackBlitz examples |
| packages/docs-examples/components/content-panel/content-panel-with-grid/content-panel-with-grid-example.ts | Migrated to AG Grid v34 API with module registration, RowSelectionOptions, and auto-generated selection column |
| packages/docs-examples/components/ag-grid/ag-grid-row-dragging/ag-grid-row-dragging-example.ts | Migrated to AG Grid v34 API with module registration, RowSelectionOptions, and auto-generated selection column |
| packages/docs-examples/components/ag-grid/ag-grid-overview/ag-grid-overview-example.ts | Migrated to AG Grid v34 API with module registration, RowSelectionOptions, and auto-generated selection column |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/docs-examples/components/ag-grid/ag-grid-row-dragging/ag-grid-row-dragging-example.ts
Outdated
Show resolved
Hide resolved
|
Visit the preview URL for this PR (updated for commit 46c5319): https://koobiq-next--prs-1135-a1hexb51.web.app (expires Sat, 29 Nov 2025 07:46:30 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c |
|
секцию "Установка" надо обновить. |
поправил |
No description provided.