-
Notifications
You must be signed in to change notification settings - Fork 3
fix(docs): sidenav options to links (#DS-4336) #1141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Visit the preview URL for this PR (updated for commit 53ccbe7): https://koobiq-next--prs-1141-rckxoib6.web.app (expires Tue, 02 Dec 2025 08:05:30 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR refactors the sidenav component to modernize its Angular patterns and improve UX by converting tree options to clickable links.
Key changes:
- Migrated from
@ViewChilddecorator toviewChild()function for component queries - Replaced getter/setter pattern with
model()function for two-way binding with tree selection - Moved template from external HTML file to inline template
- Enhanced navigation UX by wrapping tree items in
<a>tags with absolute positioning to cover the entire clickable area
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| apps/docs/src/app/components/sidenav/sidenav.component.ts | Refactored to use modern Angular patterns (viewChild, model), moved template inline, improved type safety in transformer function, and added explicit click handlers for navigation |
| apps/docs/src/app/components/sidenav/sidenav.component.scss | Replaced SASS mixin with standard CSS, migrated to CSS variables (--kbq-*), and added link styling with absolute positioning for full-area clickability |
| apps/docs/src/app/components/sidenav/sidenav.component.html | Template moved to inline format in TypeScript file (file deleted) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.