Skip to content

Conversation

@artembelik
Copy link
Contributor

No description provided.

@artembelik artembelik self-assigned this Nov 26, 2025
Copilot AI review requested due to automatic review settings November 26, 2025 10:02
@github-actions
Copy link

github-actions bot commented Nov 26, 2025

Visit the preview URL for this PR (updated for commit 53ccbe7):

https://koobiq-next--prs-1141-rckxoib6.web.app

(expires Tue, 02 Dec 2025 08:05:30 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the sidenav component to modernize its Angular patterns and improve UX by converting tree options to clickable links.

Key changes:

  • Migrated from @ViewChild decorator to viewChild() function for component queries
  • Replaced getter/setter pattern with model() function for two-way binding with tree selection
  • Moved template from external HTML file to inline template
  • Enhanced navigation UX by wrapping tree items in <a> tags with absolute positioning to cover the entire clickable area

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File Description
apps/docs/src/app/components/sidenav/sidenav.component.ts Refactored to use modern Angular patterns (viewChild, model), moved template inline, improved type safety in transformer function, and added explicit click handlers for navigation
apps/docs/src/app/components/sidenav/sidenav.component.scss Replaced SASS mixin with standard CSS, migrated to CSS variables (--kbq-*), and added link styling with absolute positioning for full-area clickability
apps/docs/src/app/components/sidenav/sidenav.component.html Template moved to inline format in TypeScript file (file deleted)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@lskramarov lskramarov changed the title refactor(docs): sidenav options to links (#DS-4336) fix(docs): sidenav options to links (#DS-4336) Nov 27, 2025
@artembelik artembelik merged commit 277a728 into main Nov 27, 2025
8 checks passed
@artembelik artembelik deleted the feat/DS-4336 branch November 27, 2025 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants