chore(e2e): single test for light & dark screenshots (#DS-4589) #1296
Conversation
|
Visit the preview URL for this PR (updated for commit fa85aee): https://koobiq-next--prs-1296-7tt493mb.web.app (expires Sun, 25 Jan 2026 10:56:28 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c |
🚨 E2E tests failedReview the report for details. 💡 Comment |
artembelik
changed the title
|
/approve-snapshots |
|
🔄 Updating snapshots. |
|
✅ Snapshots updated! |
🚨 E2E tests failedReview the report for details. 💡 Comment |
|
/approve-snapshots |
|
🔄 Updating snapshots. |
|
✅ Snapshots updated! |
There was a problem hiding this comment.
Pull request overview
This PR refactors E2E Playwright tests to consolidate light and dark theme screenshot tests into single test cases. Previously, separate test cases existed for light and dark themes. Now, a single test captures both theme screenshots sequentially with explicit filenames ('01-light.png', '01-dark.png', etc.). Additionally, a new utility function e2eWhenStable is introduced to ensure elements are stable before taking screenshots.
Changes:
- Combined separate light/dark theme tests into single tests that capture both screenshots
- Added explicit screenshot filenames following a numbered naming convention
- Introduced
e2eWhenStableutility function for element stability checking - Renamed tests to use generic names like "states" instead of theme-specific names
Reviewed changes
Copilot reviewed 54 out of 220 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/e2e/utils/when-stable.ts | New utility function to wait for element stability and visibility |
| packages/e2e/utils/index.ts | Export the new e2eWhenStable function |
| packages/components/*/e2e.playwright-spec.ts | Refactored tests to combine light/dark theme screenshots in single test cases |
| packages/components//screenshots/.png | New screenshot files with explicit naming convention |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.