Skip to content

Conversation

@artembelik
Copy link
Contributor

@artembelik artembelik commented Aug 15, 2025

we can close the panel even if it is specified disableClose

@artembelik artembelik requested a review from lskramarov August 15, 2025 13:14
@artembelik artembelik self-assigned this Aug 15, 2025
@artembelik artembelik requested a review from NikGurev as a code owner August 15, 2025 13:14
@artembelik artembelik added the bug Something isn't working label Aug 15, 2025
@github-actions
Copy link

github-actions bot commented Aug 15, 2025

Visit the preview URL for this PR (updated for commit 2b55c0f):

https://koobiq-next--prs-983-kspfqep7.web.app

(expires Sat, 23 Aug 2025 14:14:08 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug where clicking on the sidepanel indent (background area) would close the panel even when disableClose was set to true. The fix ensures that indent clicks respect the disableClose configuration by routing through the proper close mechanism instead of calling exit() directly.

Key Changes:

  • Added an observable stream for indent click events that respects the sidepanel's close behavior
  • Modified the indent click handler to emit events through this stream rather than directly calling exit()
  • Updated tests to verify both scenarios: closing when allowed and staying open when disableClose is true

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tools/public_api_guard/components/sidepanel.api.md Added public API exports for the new indent click observable functionality
packages/components/sidepanel/sidepanel.spec.ts Added test cases to verify indent click behavior with and without disableClose
packages/components/sidepanel/sidepanel-ref.ts Updated close subscription to include indent click events alongside ESC key events
packages/components/sidepanel/sidepanel-container.component.ts Implemented indent click observable with Subject and public method
packages/components/sidepanel/sidepanel-container.component.html Changed indent click handler from direct exit() call to emit through Subject

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@lskramarov lskramarov merged commit 30db66d into main Aug 18, 2025
4 checks passed
@lskramarov lskramarov deleted the fix/DS-4053 branch August 18, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants